From: Fabio Estevam <festevam@gmail.com>
To: Alifer Moraes <alifer.wsdm@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Marco Franchi <marco.franchi@nxp.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: imx8mq-phanbell: Fix Ethernet PHY post-reset duration
Date: Fri, 13 Mar 2020 13:49:33 -0300 [thread overview]
Message-ID: <CAOMZO5CNv3zzgDEK6R=K4f04NyJKHeSb_4sj8ynF_be1tKeV7Q@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5BjAN8rJ25n2n3i=gVQ_noo-X8CTsFDZWBQB88SyZ-SNg@mail.gmail.com>
On Fri, Mar 13, 2020 at 1:32 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Alifer,
>
> On Fri, Mar 6, 2020 at 7:41 AM Alifer Moraes <alifer.wsdm@gmail.com> wrote:
> >
> > i.MX8MQ Phanbell board uses Realtek RTL8211FD as Ethernet PHY.
> > Its datasheet states that the proper post reset duration should be at least 50 ms.
>
> The datasheet I found in the web states:
>
> "The RTL8211F(I)/RTL8211FD(I) has a PHYRSTB pin to reset the chip. For
> a complete PHY reset, this pin must be asserted low for at least 10ms
> (Tgap in Figure 9) for the internal regulator. Wait for a further 30ms
> (for internal circuits settling time) before accessing the PHY
> register"
>
> Where does the 50ms requirement come from? Do you have an updated
> datasheet that says 50ms instead?
Just found this one:
https://datasheet.lcsc.com/szlcsc/1909021205_Realtek-Semicon-RTL8211F-CG_C187932.pdf
Which says "Wait for at least 50ms* (for internal circuits settling
time) before accessing the PHY register.", so your patch is correct,
thanks.
This also fixes Ethernet in U-Boot, so:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
prev parent reply other threads:[~2020-03-13 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 10:42 [PATCH] arm64: dts: imx8mq-phanbell: Fix Ethernet PHY post-reset duration Alifer Moraes
2020-03-13 16:32 ` Fabio Estevam
2020-03-13 16:49 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5CNv3zzgDEK6R=K4f04NyJKHeSb_4sj8ynF_be1tKeV7Q@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=alifer.wsdm@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.franchi@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).