From: Fabio Estevam <festevam@gmail.com>
To: "Vokáč Michal" <Michal.Vokac@ysoft.com>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards
Date: Fri, 28 Dec 2018 16:20:37 -0200 [thread overview]
Message-ID: <CAOMZO5CuPr_BxMP_wjPuZNTCinHQ-cb08wPHr=Od_Qw_aafPTw@mail.gmail.com> (raw)
In-Reply-To: <1545144107-88378-1-git-send-email-michal.vokac@ysoft.com>
Hi Vokáč,
On Tue, Dec 18, 2018 at 12:42 PM Vokáč Michal <Michal.Vokac@ysoft.com> wrote:
> +&fec {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_enet>;
> + phy-mode = "rgmii-id";
> + phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_HIGH>;
Are you sure this is active high?
The FEC driver ignores the polarity of phy-reset-gpios and it assumes
the GPIO reset as active low.
If it really is active high, then you would need to pass the
"phy-reset-active-high" property.
> +/ {
> + model = "Y Soft IOTA Draco i.MX6Solo board";
> + compatible = "ysoft,imx6dl-yapp4-draco", "fsl,imx6dl";
> +
> + cpus {
> + /delete-node/ cpu@1;
Is this really needed? We don't usually do this on imx6solo dts board files.
Only one CPU will be brought up online on imx6solo anyway.
> + };
> +
> + memory@10000000 {
Need to pass "device_type = "memory";"
> +/ {
> + model = "Y Soft IOTA Hydra i.MX6DualLite board";
> + compatible = "ysoft,imx6dl-yapp4-hydra", "fsl,imx6dl";
> +
> + memory@10000000 {
Need to pass "device_type = "memory";"
> + memory@10000000 {
Need to pass "device_type = "memory";"
next prev parent reply other threads:[~2018-12-28 18:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 14:42 [PATCH v2] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards Vokáč Michal
2018-12-28 18:20 ` Fabio Estevam [this message]
2019-01-08 11:40 ` Vokáč Michal
2018-12-28 23:25 ` Rob Herring
2019-01-08 11:43 ` Vokáč Michal
2019-01-08 14:25 ` Vokáč Michal
2019-01-08 14:53 ` Rob Herring
2019-01-08 14:56 ` Rob Herring
2019-01-08 15:00 ` Vokáč Michal
2019-01-08 16:09 ` Vokáč Michal
2019-01-08 18:11 ` Rob Herring
2019-01-10 13:57 ` Shawn Guo
2019-01-10 14:06 ` Vokáč Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5CuPr_BxMP_wjPuZNTCinHQ-cb08wPHr=Od_Qw_aafPTw@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=Michal.Vokac@ysoft.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).