From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B90EAC3524B for ; Sun, 2 Feb 2020 16:39:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 908232080D for ; Sun, 2 Feb 2020 16:39:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XoUUS+o3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726992AbgBBQjy (ORCPT ); Sun, 2 Feb 2020 11:39:54 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:42455 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726907AbgBBQjx (ORCPT ); Sun, 2 Feb 2020 11:39:53 -0500 Received: by mail-lf1-f65.google.com with SMTP id y19so8026837lfl.9; Sun, 02 Feb 2020 08:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZVaC0F6rgdniTKROUmCnnA4r9wsKzEyhP6hHedwGoWo=; b=XoUUS+o3zhjNpAbUAUIfkj/DPoLWtowdwYUaTHzcwfzGiWEvDtnGA0vFtlP/shH3Vo 25dS7EkTu8G7uCL7S/SjtLAhWZe9JAEAwq4eOCUOTW82/yN4sRnb+6gZmO8M4zYMtsQT 5jGkW4xhG1S/8gELd3Oapxj2sn4N0CMam04YmPY6py7ZqQdQhhhofHzeb67kzv4QoH8M 0GXtRajwA83o+0WP59UES85ARZjANg3xULWrkuueaHQC8pTSq6ut/DMAydv1Q351UTsV pLn76PMJNYr6w1MdaJb+lZRGW0wbiOBB2DJXtBj2KQ/6eZDXu59Ar2grySPYG9JSw3Hn 4/8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZVaC0F6rgdniTKROUmCnnA4r9wsKzEyhP6hHedwGoWo=; b=VSbnGTPQJeUOJlenCLhV3/U7B/qYL0dTvbTCAuoQ3KCnGRpZvWXcPJyC1t5sAm9OhF bWprzyvuJoXQlUu9nqSHD+X8UHhzH7NbKOvC7Ea6IOvd6cO5oUKTwIJyklfHwjYu0h9a Vt/oWgnxiqwTtZ1RhzLtC0NzjUm6Lt0HJXDKvuwa/iWeQFQHQIznd4YWpa2NSPJTt8ZI /jMOqH7XIVdHTts+tirxl69jPWM0qWEJhAGC2pUtJMuO8VdHzOAPfxHGl657Oc6vXOGB j0F7OHCcjwJObZ4egfNAgFiuDPzCVARt+O2SYgfGBLf9ZXavIaRrErZ5Kdks9mukNekj fW5A== X-Gm-Message-State: APjAAAUsmbR03YVFUtyU803F861X5iR2IcvX82QbBwJoSu5Wtlf6wlus fFaLdJaRS0SIODJN7cta3CDpksYgRnkEicW95iQ= X-Google-Smtp-Source: APXvYqzzlxrTpJnf9hamU4U8roypGWc+64P/nSJO0cYNO9R2+JV7vqrhizVneA72cA7hYjmojWIPthZlH0pd8OGiFsY= X-Received: by 2002:a19:c3c2:: with SMTP id t185mr9929668lff.56.1580661590508; Sun, 02 Feb 2020 08:39:50 -0800 (PST) MIME-Version: 1.0 References: <20200202125950.1825013-1-aford173@gmail.com> <20200202125950.1825013-2-aford173@gmail.com> In-Reply-To: <20200202125950.1825013-2-aford173@gmail.com> From: Fabio Estevam Date: Sun, 2 Feb 2020 13:39:41 -0300 Message-ID: Subject: Re: [PATCH V2 2/5] spi: fspi: dynamically alloc AHB memory To: Adam Ford Cc: linux-spi , Han Xu , Yogesh Gaur , Ashish Kumar , Mark Brown , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 2, 2020 at 10:00 AM Adam Ford wrote: > > From: Han Xu > > Apply patch from NXP upstream repo to > dynamically allocate AHB memory as needed. The commit log could be improved here. What is the motivation for doing this? > + if (!f->ahb_addr) { > + dev_err(f->dev, "failed to alloc memory\n"); There is no need for this error message as the MM core will take care of it.