From: Fabio Estevam <festevam@gmail.com>
To: Marco Franchi <marco.franchi@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Marco Antonio Franchi <marcofrk@gmail.com>
Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Add DRM panel, power-enable and backlight support
Date: Fri, 1 Dec 2017 18:27:14 -0200 [thread overview]
Message-ID: <CAOMZO5D4FMcLuGoh8JPRpdXaqPTOGgvWd39OV7qkZqVzptr87A@mail.gmail.com> (raw)
In-Reply-To: <1512046929-18597-1-git-send-email-marco.franchi@nxp.com>
The Subject could be improved to something like: Convert from fbdev to
drm bindings
On Thu, Nov 30, 2017 at 11:02 AM, Marco Franchi <marco.franchi@nxp.com> wrote:
> It is preferred to use the panel compatible string rather than passing
> the LCD timming in the device tree.
Typo: timing
>
> So pass the "sii,43wvf1g" compatible string, a new driver for the Seiko
> Panel, which describes the parallel LCD.
Please remove the "a new driver for the Seiko Panel".
>
> This new driver needs two power supply, so pass 'dvdd-supply' and
> 'avdd-supply', which makes the kernel to turn on the LCD on is own.
I would remove this too.
>
> Also, pass the 'backlight' property as described in
> Documentation/devicetree/bindings/display/panel/simple-panel.txt
>
> Signed-off-by: Marco Franchi <marco.franchi@nxp.com>
> ---
> arch/arm/boot/dts/imx6sx-sdb.dtsi | 49 ++++++++++++++++++++-------------------
> 1 file changed, 25 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6sx-sdb.dtsi b/arch/arm/boot/dts/imx6sx-sdb.dtsi
> index da81552..3a597a4 100644
> --- a/arch/arm/boot/dts/imx6sx-sdb.dtsi
> +++ b/arch/arm/boot/dts/imx6sx-sdb.dtsi
> @@ -24,7 +24,7 @@
> reg = <0x80000000 0x40000000>;
> };
>
> - backlight {
> + backlight_display: backlight-display {
> compatible = "pwm-backlight";
> pwms = <&pwm3 0 5000000>;
> brightness-levels = <0 4 8 16 32 64 128 255>;
> @@ -129,6 +129,14 @@
> regulator-max-microvolt = <3300000>;
> gpios = <&gpio2 6 GPIO_ACTIVE_LOW>;
> };
> +
> + reg_lcd_5v: regulator@7 {
> + compatible = "regulator-fixed";
> + reg = <7>;
> + regulator-name = "lcd-5v0";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + };
I have sent a patch that removes the regulators from simple-panel.
Please use linux-next when you send a v2.
prev parent reply other threads:[~2017-12-01 20:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 13:02 [PATCH] ARM: dts: imx6sx-sdb: Add DRM panel, power-enable and backlight support Marco Franchi
2017-12-01 20:27 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5D4FMcLuGoh8JPRpdXaqPTOGgvWd39OV7qkZqVzptr87A@mail.gmail.com \
--to=festevam@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.franchi@nxp.com \
--cc=marcofrk@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).