From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751618AbcKFTn4 (ORCPT <rfc822;w@1wt.eu>);
        Sun, 6 Nov 2016 14:43:56 -0500
Received: from mail-ua0-f179.google.com ([209.85.217.179]:32994 "EHLO
        mail-ua0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751042AbcKFTnz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 6 Nov 2016 14:43:55 -0500
MIME-Version: 1.0
In-Reply-To: <7ea1cd5a-9215-18ed-2412-b6860a0b708f@infradead.org>
References: <7ea1cd5a-9215-18ed-2412-b6860a0b708f@infradead.org>
From: Fabio Estevam <festevam@gmail.com>
Date: Sun, 6 Nov 2016 17:43:53 -0200
Message-ID: <CAOMZO5DPP7suoCzSjkSzCugiC-nCNcLL8Xn68QdgaC3M9P_=cA@mail.gmail.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl: fix fsl_spdif.c build errors
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Timur Tabi <timur@tabi.org>, Nicolin Chen <nicoleotsuka@gmail.com>,
        Xiubo Li <Xiubo.Lee@gmail.com>, Fabio Estevam <fabio.estevam@nxp.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Geliang Tang <geliangtang@163.com>,
        moderated for non-subscribers <alsa-devel@alsa-project.org>,
        LKML <linux-kernel@vger.kernel.org>, Kees Cook <keescook@chromium.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Randy,

On Sat, Nov 5, 2016 at 9:16 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors in sound/soc/fsl/fsl_spdif.c by selecting BITREVERSE.
> Fixes these build errors:

Care to explain why the error is happening?

> sound/built-in.o: In function `spdif_write_channel_status':
> fsl_spdif.c:(.text+0xbe39d): undefined reference to `byte_rev_table'
> fsl_spdif.c:(.text+0xbe3a8): undefined reference to `byte_rev_table'
> fsl_spdif.c:(.text+0xbe3be): undefined reference to `byte_rev_table'
> fsl_spdif.c:(.text+0xbe3d8): undefined reference to `byte_rev_table'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Applies-to: all 3.x, all 4.x

Not sure if this last line is correct. The kbuild report says this
error starts to happen with:
commit: 8cfc8ddc99df9509a46043b14af81f5c6a223eab pstore: add lzo/lz4
compression support

on a x86_64 randconfig.

Also, why only SND_SOC_FSL_SPDIF needs to have BITREVERSE selected?