From: Fabio Estevam <festevam@gmail.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Chris Ball <cjb@laptop.org>,
linux-samsung-soc@vger.kernel.org,
James Hogan <james.hogan@imgtec.com>,
Seungwon Jeon <tgih.jun@samsung.com>,
linux-kernel@vger.kernel.org, Olof Johansson <olof@lixom.net>,
linux-mmc@vger.kernel.org, Tomasz Figa <tomasz.figa@gmail.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Grant Grundler <grundler@chromium.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Abhilash Kesavan <a.kesavan@samsung.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT
Date: Fri, 9 Aug 2013 13:41:58 -0300 [thread overview]
Message-ID: <CAOMZO5DZ=aJsOvTyrKL=57_jGMGQX8k3mDamgXqnF-9Ou2fpAg@mail.gmail.com> (raw)
In-Reply-To: <1376066000-5495-3-git-send-email-dianders@chromium.org>
On Fri, Aug 9, 2013 at 1:33 PM, Doug Anderson <dianders@chromium.org> wrote:
> +#else
> +#define dw_mci_exynos_suspend NULL
> +#define dw_mci_exynos_resume NULL
> +#define dw_mci_exynos_resume_noirq NULL
> +#endif /* CONFIG_PM_SLEEP */
You could avoid this else block if you use 'static SIMPLE_DEV_PM_OPS' below.
> +
> static void dw_mci_exynos_prepare_command(struct dw_mci *host, u32 *cmdr)
> {
> /*
> @@ -187,13 +234,20 @@ static int dw_mci_exynos_probe(struct platform_device *pdev)
> return dw_mci_pltfm_register(pdev, drv_data);
> }
>
> +const struct dev_pm_ops dw_mci_exynos_pmops = {
> + SET_SYSTEM_SLEEP_PM_OPS(dw_mci_exynos_suspend, dw_mci_exynos_resume)
> + .resume_noirq = dw_mci_exynos_resume_noirq,
> + .thaw_noirq = dw_mci_exynos_resume_noirq,
> + .restore_noirq = dw_mci_exynos_resume_noirq,
> +};
static SIMPLE_DEV_PM_OPS(dw_mci_exynos_pmops, dw_mci_exynos_suspend,
dw_mci_exynos_resume ) ;
next prev parent reply other threads:[~2013-08-09 16:42 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 17:31 [PATCH 0/5] mmc: dw_mmc: fixes for suspend/resume on exynos Doug Anderson
2013-07-09 17:31 ` [PATCH 1/5] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume Doug Anderson
2013-07-09 17:31 ` [PATCH 2/5] mmc: dw_mmc: Add suspend/resume callbacks; disable irq during suspend Doug Anderson
2013-07-09 21:17 ` James Hogan
2013-07-09 21:31 ` Doug Anderson
2013-07-09 17:31 ` [PATCH 3/5] mmc: dw_mmc: Add exynos resume callback to clear WAKEUP_INT Doug Anderson
2013-07-09 19:09 ` Doug Anderson
2013-07-11 0:43 ` Grant Grundler
2013-07-09 17:31 ` [PATCH 4/5] mmc: dw_mmc: Always setup the bus after suspend/resume Doug Anderson
2013-07-09 17:31 ` [PATCH 5/5] mmc: dw_mmc: Set timeout to max upon resume Doug Anderson
2013-07-09 23:19 ` [PATCH v2 0/5] mmc: dw_mmc: fixes for suspend/resume on exynos Doug Anderson
2013-07-09 23:19 ` [PATCH v2 1/5] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume Doug Anderson
2013-07-09 23:19 ` [PATCH v2 2/5] mmc: dw_mmc: Add suspend_noirq/resume_noirq callbacks for dw_mmc-pltfm Doug Anderson
2013-07-10 8:37 ` James Hogan
2013-07-10 15:08 ` Doug Anderson
2013-07-09 23:19 ` [PATCH v2 3/5] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT Doug Anderson
2013-07-10 14:54 ` Seungwon Jeon
2013-07-10 15:05 ` Doug Anderson
2013-07-15 12:09 ` Seungwon Jeon
2013-07-31 16:18 ` Doug Anderson
2013-08-06 21:36 ` Doug Anderson
2013-07-09 23:19 ` [PATCH v2 4/5] mmc: dw_mmc: Always setup the bus after suspend/resume Doug Anderson
2013-07-09 23:19 ` [PATCH v2 5/5] mmc: dw_mmc: Set timeout to max upon resume Doug Anderson
2013-07-10 14:54 ` Seungwon Jeon
2013-07-10 15:42 ` [PATCH v3 0/5] mmc: dw_mmc: fixes for suspend/resume on exynos Doug Anderson
2013-07-10 15:42 ` [PATCH v3 1/5] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume Doug Anderson
2013-07-10 15:42 ` [PATCH v3 2/5] mmc: dw_mmc: Add suspend_noirq/resume_noirq callbacks for dw_mmc-pltfm Doug Anderson
2013-07-15 12:09 ` Seungwon Jeon
2013-08-06 21:32 ` Doug Anderson
2013-07-10 15:42 ` [PATCH v3 3/5] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT Doug Anderson
2013-07-16 1:36 ` Jaehoon Chung
2013-07-10 15:42 ` [PATCH v3 4/5] mmc: dw_mmc: Always setup the bus after suspend/resume Doug Anderson
2013-07-10 15:42 ` [PATCH v3 5/5] mmc: dw_mmc: Set timeout to max upon resume Doug Anderson
2013-08-06 21:37 ` [PATCH v4 0/4] mmc: dw_mmc: fixes for suspend/resume on exynos Doug Anderson
2013-08-06 21:37 ` [PATCH v4 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume Doug Anderson
2013-08-06 21:58 ` Tomasz Figa
2013-08-08 5:14 ` Jaehoon Chung
2013-08-09 13:32 ` Seungwon Jeon
2013-08-09 15:22 ` Doug Anderson
2013-08-12 7:14 ` Seungwon Jeon
2013-08-22 0:54 ` Doug Anderson
2013-08-22 16:25 ` Doug Anderson
2013-08-06 21:37 ` [PATCH v4 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT Doug Anderson
2013-08-06 21:58 ` Tomasz Figa
2013-08-06 22:09 ` Doug Anderson
2013-08-06 22:20 ` Tomasz Figa
2013-08-09 13:33 ` Seungwon Jeon
2013-08-09 15:05 ` Doug Anderson
2013-08-06 21:37 ` [PATCH v4 3/4] mmc: dw_mmc: Always setup the bus after suspend/resume Doug Anderson
2013-08-06 22:01 ` Tomasz Figa
2013-08-09 13:35 ` Seungwon Jeon
2013-08-09 15:43 ` Doug Anderson
2013-08-12 7:20 ` Seungwon Jeon
2013-08-06 21:37 ` [PATCH v4 4/4] mmc: dw_mmc: Set timeout to max upon resume Doug Anderson
2013-08-06 22:02 ` Tomasz Figa
2013-08-09 16:33 ` [PATCH v5 0/4] mmc: dw_mmc: fixes for suspend/resume on exynos Doug Anderson
2013-08-09 16:33 ` [PATCH v5 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume Doug Anderson
2013-08-09 16:33 ` [PATCH v5 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT Doug Anderson
2013-08-09 16:41 ` Fabio Estevam [this message]
2013-08-09 16:48 ` Doug Anderson
2013-08-12 7:21 ` Seungwon Jeon
2013-08-09 16:33 ` [PATCH v5 3/4] mmc: dw_mmc: Always setup the bus after suspend/resume Doug Anderson
2013-08-09 16:33 ` [PATCH v5 4/4] mmc: dw_mmc: Set timeout to max upon resume Doug Anderson
2013-08-21 11:48 ` [PATCH v5 0/4] mmc: dw_mmc: fixes for suspend/resume on exynos Seungwon Jeon
2013-08-21 15:13 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5DZ=aJsOvTyrKL=57_jGMGQX8k3mDamgXqnF-9Ou2fpAg@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=a.kesavan@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=cjb@laptop.org \
--cc=dianders@chromium.org \
--cc=grundler@chromium.org \
--cc=james.hogan@imgtec.com \
--cc=jh80.chung@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=tgih.jun@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).