From: Fabio Estevam <festevam@gmail.com>
To: Abel Vesa <abel.vesa@nxp.com>
Cc: "shawnguo@kernel.org" <shawnguo@kernel.org>,
Anson Huang <anson.huang@nxp.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Adriana Reus <adriana.reus@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"abelvesa@linux.com" <abelvesa@linux.com>
Subject: Re: Return checks for clock calls
Date: Fri, 23 Mar 2018 21:27:14 -0300 [thread overview]
Message-ID: <CAOMZO5Da0GbkC1vjjbyNmG77gvd-KO8HC-2oBYxAffNHCtEDKw@mail.gmail.com> (raw)
In-Reply-To: <20180323094937.5wx5exah6tfyl43u@fsr-ub1664-175>
Hi Abel,
On Fri, Mar 23, 2018 at 6:49 AM, Abel Vesa <abel.vesa@nxp.com> wrote:
> Hi Shawn, Fabio,
>
> I'm trying to get the imx clks changes upstreamed. To that end, I reached this
> old commit that adds some wrappers over the generic clk API. Here is the commit
> message:
>
> ARM: imx6: add return check for clock calls
>
> There are a bunch of clk_enable_prepare, clk_set_parent and clk_set_rate
> calls in imx6 clock driver's initialization. They are called without
> retunr check. If there is something going wrong with the calls, they
> will just fail silently.
>
> The patch creates a set of helper functions imx_clk_enable_prepare,
> imx_clk_set_parent and imx_clk_set_rate, and use them instead from clock
> initialization to check the return and print error message to tell
> failures if any.
>
> Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
>
> And it adds the imx_clk_set_parent, imx_clk_prepare_enable and
> imx_clk_set_rate which basically just print an error message if the generic
> functions have failed.
>
> The only plus of these wrappers is that we at least see that the generic
> functions have failed, but the behaviour is not changed in any way.
>
> Question is, do we want this upstreamed considering that we need to replace the
> calls throughout all the older imx socs ?
IMHO we should not introduce these new helper functions.
We can simply explicitly check for errors with the existing clock
functions when needed.
prev parent reply other threads:[~2018-03-24 0:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 9:49 Return checks for clock calls Abel Vesa
2018-03-24 0:27 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5Da0GbkC1vjjbyNmG77gvd-KO8HC-2oBYxAffNHCtEDKw@mail.gmail.com \
--to=festevam@gmail.com \
--cc=abel.vesa@nxp.com \
--cc=abelvesa@linux.com \
--cc=adriana.reus@nxp.com \
--cc=anson.huang@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).