From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753595AbaKSM7y (ORCPT ); Wed, 19 Nov 2014 07:59:54 -0500 Received: from mail-la0-f47.google.com ([209.85.215.47]:47766 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbaKSM7x (ORCPT ); Wed, 19 Nov 2014 07:59:53 -0500 MIME-Version: 1.0 In-Reply-To: <1416400568-7512-1-git-send-email-b50113@freescale.com> References: <1416400568-7512-1-git-send-email-b50113@freescale.com> Date: Wed, 19 Nov 2014 10:59:51 -0200 Message-ID: Subject: Re: [alsa-devel] [PATCH] ASoC: wm8960: Add shared_lrclk and capless to device tree From: Fabio Estevam To: Zidan Wang Cc: Mark Brown , "alsa-devel@alsa-project.org" , Lars-Peter Clausen , Takashi Iwai , linux-kernel , patches@opensource.wolfsonmicro.com, Liam Girdwood , Xiubo Li , Charles Keepax Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 19, 2014 at 10:36 AM, Zidan Wang wrote: > wm8960 codec has a wm8960_data struct which has two fields shared_lrclk and capless. > The wm8960_data is get from platform_data and it is reasonable to set it from device > tree when platform_data is null. > And when shared_lrclk is set, LRCM will be enabled. But the following software reset > in wm8960_probe will reset it to the default state. So LRCM operation should after > software reset. > > Signed-off-by: Zidan Wang > --- > sound/soc/codecs/wm8960.c | 49 ++++++++++++++++++++++++++++++----------------- I think you could a add Documentation/devicetree/bindings/sound/wm8960.txt in a separate patch and document these properties there.