From: Fabio Estevam <festevam@gmail.com>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
michal.lkml@markovi.net, nicolas.palix@imag.fr,
linux-kernel <linux-kernel@vger.kernel.org>,
cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple
Date: Sat, 13 Jan 2018 17:13:36 -0200 [thread overview]
Message-ID: <CAOMZO5DvY-5kjzD8fKWkR2PhgT3HO7tT_fAZnuomBx+woLqH6g@mail.gmail.com> (raw)
In-Reply-To: <20180113175353.GA3513@himanshu-Vostro-3559>
On Sat, Jan 13, 2018 at 3:53 PM, Himanshu Jha
<himanshujha199640@gmail.com> wrote:
> Yes, I used 'git mv'.
>
> It doesn't matter when applying through 'git am', both will result the
> same AFAIK and only difference is that the patch files generated by 'git
> format-patch' are different. But that is not important I think.
You missed the -M option when running 'git format'.
For reviewers it is not that easy to realize that the 448 lines of the
original file are the same as the ones in the new file.
The -M option generates a much cleaner patch.
next prev parent reply other threads:[~2018-01-13 19:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 15:57 [PATCH] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple Himanshu Jha
2018-01-13 16:27 ` Julia Lawall
2018-01-13 17:02 ` [Cocci] " Fabio Estevam
2018-01-13 17:53 ` Himanshu Jha
2018-01-13 19:13 ` Fabio Estevam [this message]
2018-01-13 19:52 ` Himanshu Jha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5DvY-5kjzD8fKWkR2PhgT3HO7tT_fAZnuomBx+woLqH6g@mail.gmail.com \
--to=festevam@gmail.com \
--cc=cocci@systeme.lip6.fr \
--cc=himanshujha199640@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).