From: Michal Suchanek <hramrach@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: linux-sunxi <linux-sunxi@googlegroups.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"David Woodhouse" <dwmw2@infradead.org>,
"Brian Norris" <computersforpeace@gmail.com>,
"Huang Shijie" <b32955@freescale.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Ben Hutchings" <ben@decadent.org.uk>,
"Alison Chaiken" <alison_chaiken@mentor.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Bean Huo 霍斌斌 (beanhuo)" <beanhuo@micron.com>,
"grmoore@altera.com" <grmoore@altera.com>,
devicetree <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/3] MTD: m25p80: fix write return value.
Date: Thu, 30 Apr 2015 23:37:58 +0200 [thread overview]
Message-ID: <CAOMqctQes17hiccCfbX5=pnTkPv2H+MxkYaPFx-XkgmF+SiXfg@mail.gmail.com> (raw)
In-Reply-To: <201504302043.11118.marex@denx.de>
On 30 April 2015 at 20:43, Marek Vasut <marex@denx.de> wrote:
> On Thursday, April 30, 2015 at 03:33:47 PM, Michal Suchanek wrote:
>> The size of written data was added to user supplied value rather than
>> written at the provided address.
>
> You might want to work on the commit message a little, something like
> the following, but feel free to reword as seen fit.
>
> The 'retlen' points to a variable representing the number of data bytes
> written/read (see include/linux/mtd/mtd.h) by the current invocation of
> the function. This variable must be set, not incremented.
>
> Otherwise, the patch is correct I believe:
>
> Acked-by: Marek Vasut <marex@denx.de>
>
ok, I will send an updated version.
Thanks
Michal
next prev parent reply other threads:[~2015-04-30 21:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1430403750.git.hramrach@gmail.com>
[not found] ` <3b0c112672f364452e80c333048161eaffb655db.1430403750.git.hramrach@gmail.com>
2015-04-30 14:58 ` [linux-sunxi] [PATCH 3/3] MTD: m25p80: Add option to limit SPI transfer size Julian Calaby
2015-05-20 23:27 ` Brian Norris
2015-04-30 16:30 ` [PATCH 0/3] Using SPI NOR flah on sunxi Thomas.Betker
2015-04-30 16:56 ` Michal Suchanek
2015-04-30 18:34 ` Marek Vasut
2015-05-20 23:54 ` Brian Norris
[not found] ` <55132b4496e7fe73f949186c0f140f3e4fd4e2c7.1430403750.git.hramrach@gmail.com>
2015-04-30 18:43 ` [PATCH 1/3] MTD: m25p80: fix write return value Marek Vasut
2015-04-30 21:37 ` Michal Suchanek [this message]
[not found] ` <jwv4mnwfppf.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi@gnu.org>
2015-05-04 10:32 ` [linux-sunxi] Re: [PATCH 0/3] Using SPI NOR flah on sunxi Michal Suchanek
[not found] ` <50c40ef17ab6566f35ef5a4426bf23567f896db7.1430403750.git.hramrach@gmail.com>
2015-05-20 23:38 ` [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write Brian Norris
2015-05-21 8:39 ` Michal Suchanek
2015-05-21 10:28 ` Mark Brown
2015-05-22 7:17 ` Brian Norris
2015-05-22 7:25 ` Brian Norris
2015-05-22 9:37 ` Mark Brown
[not found] <cover.1430430153.git.hramrach@gmail.com>
[not found] ` <02f7510acb9b6dbb3a5a6cd5bb287762eb4d22c1.1430430153.git.hramrach@gmail.com>
2015-04-30 23:09 ` [PATCH 1/3] MTD: m25p80: fix write return value Marek Vasut
2015-05-20 23:45 ` Brian Norris
2015-05-21 8:33 ` Michal Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMqctQes17hiccCfbX5=pnTkPv2H+MxkYaPFx-XkgmF+SiXfg@mail.gmail.com' \
--to=hramrach@gmail.com \
--cc=alison_chaiken@mentor.com \
--cc=b32955@freescale.com \
--cc=beanhuo@micron.com \
--cc=ben@decadent.org.uk \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=grmoore@altera.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).