From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755574AbcFQKfc (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 Jun 2016 06:35:32 -0400
Received: from mail-wm0-f66.google.com ([74.125.82.66]:36066 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752094AbcFQKf0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Jun 2016 06:35:26 -0400
MIME-Version: 1.0
In-Reply-To: <20160613195716.GD9354@lukather>
References: <cover.1465490774.git.hramrach@gmail.com> <20160613195716.GD9354@lukather>
From: Michal Suchanek <hramrach@gmail.com>
Date: Fri, 17 Jun 2016 12:34:44 +0200
Message-ID: <CAOMqctS6ZQ3_a97sE2e7H34ZCny2aDE38V1tQA=-SBZwF2sbDQ@mail.gmail.com>
Subject: Re: [PATCH v3 00/13] sunxi spi fixes
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-sunxi <linux-sunxi@googlegroups.com>, stable@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Chen-Yu Tsai <wens@csie.org>,
        Russell King <linux@armlinux.org.uk>, Mark Brown <broonie@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        Simon Horman <horms+renesas@verge.net.au>,
        Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
        Thierry Reding <treding@nvidia.com>,
        Alison Wang <b18965@freescale.com>,
        Timo Sigurdsson <public_timo.s@silentcreek.de>,
        Jonathan Liu <net147@gmail.com>,
        Gerhard Bertelsmann <info@gerhard-bertelsmann.de>,
        Priit Laes <plaes@plaes.org>, devicetree <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-spi <linux-spi@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

On 13 June 2016 at 21:57, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Mon, Jun 13, 2016 at 05:46:48PM -0000, Michal Suchanek wrote:
>> Hello,
>>
>> This is update of the sunxi spi patches that should give full-featured SPI
>> driver.
>>
>> First three patches fix issues with the current driver and can be of use for
>> stable kernels so adding cc for those.
>>
>> I merged the sun4i and sun6i driver because there several issues that need to
>> be fixed in both separately and they are even out of sync wrt some fixes.
>> I guess some of the merge patches can be squashed.
>>
>> I tested this with A10s Olinuxino Micro. I have no sun6i device so I cannot
>> tell if that side was broken by this patchset - especially the last patch that
>> adds DMA was afaik never tested on sun6i.
>

>
> For the record, I'm still very much opposed to such a merge.
>

What is the reason against the merge? I did not find the original discussion.

I tried to rename everything in the drivers from sun4i and sun6i to
sunxi to look at a clean diff and found about 5 differences 2 of which
look like a bug.

Thanks

Michal