From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754755AbcEaOUQ (ORCPT ); Tue, 31 May 2016 10:20:16 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:32957 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754107AbcEaOUK (ORCPT ); Tue, 31 May 2016 10:20:10 -0400 MIME-Version: 1.0 In-Reply-To: <20160531132706.GC29837@sirena.org.uk> References: <20160530112610.GJ29837@sirena.org.uk> <20160530150343.GL29837@sirena.org.uk> <20160530155016.GO29837@sirena.org.uk> <20160531132706.GC29837@sirena.org.uk> From: Michal Suchanek Date: Tue, 31 May 2016 16:19:28 +0200 Message-ID: Subject: Re: [PATCH 5/5] RFC spi: sun4i: add DMA support To: Mark Brown Cc: Geert Uytterhoeven , linux-sunxi , Maxime Ripard , Chen-Yu Tsai , linux-spi , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31 May 2016 at 15:27, Mark Brown wrote: > On Tue, May 31, 2016 at 12:44:54PM +0200, Michal Suchanek wrote: >> On 30 May 2016 at 17:50, Mark Brown wrote: >> > On Mon, May 30, 2016 at 05:28:10PM +0200, Michal Suchanek wrote: > >> >> It's what the driver did to start with and it was requested to fall >> >> back to non-DMA in the case DMA is not available. > >> > Why? I really can't see any sensible use case for this that doesn't >> > have a better solution available. > >> Of course, the solution is to compile in the DMA driver. > >> It's been argued that some drivers which use only short transfers will >> just work. > > With nothing else in the system that needs DMA? It's making the > performance of the system less reliable for the benefit of a very narrow > use case. Some of the platform devices have dedicated DMA *controller* built into the device IP so the DMA engine really is optional on many sunxi devices. Besides SPI you definitely need the DMA engine for audio. You probably don't need it for storage and graphics. I don't have any idea if it's used for USB and Ethernet. Thanks Michal