From: Amir Goldstein <email@example.com> To: Phillip Potter <firstname.lastname@example.org> Cc: Al Viro <email@example.com>, linux-kernel <firstname.lastname@example.org>, linux-fsdevel <email@example.com> Subject: Re: [RFC][PATCH v3 01/10] fs: common implementation of file type Date: Wed, 24 Oct 2018 13:06:57 +0300 [thread overview] Message-ID: <CAOQ4uxjJz+WLGdhW8_y715h0BRdhitUzdSAQHn74_4Xfirstname.lastname@example.org> (raw) In-Reply-To: <20181024095601.GA19974@pathfinder> On Wed, Oct 24, 2018 at 12:56 PM Phillip Potter <email@example.com> wrote: > > On Wed, Oct 24, 2018 at 12:44:50PM +0300, Amir Goldstein wrote: ... > > Well, I did request to change some content (the location and the comment > > above BUILD_BUG_ON section) which is relevant for several patches. > > However, so far affected patched did not get any Reviewed-by. > > > > Thanks, > > Amir. > > Sorry, I missed that bit at the end, was too keen to click through to the > note about the alleged ext2 bug :-) I will make sure those changes are made > as well. By location do you mean the location of the v3, v2, etc. stuff and > your point about including it in the main [0/10] message rather than the > patches themselves? Again, thank you for your feedback and for being patient > with me, I really do appreciate it. > By location I meant place BUILD_BUG_ON() at the beginning of ext2_set_de_type() and not nested inside inner scope of ext2_readdir(). And find similar appropriate places for other patches. And one more thing for next posting - LKML is probably a too wide forum for this filesystems cleanup series. Cheers, Amir.
next prev parent reply other threads:[~2018-10-24 10:07 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-23 20:19 Phillip Potter 2018-10-24 6:16 ` Amir Goldstein 2018-10-24 8:21 ` Phillip Potter 2018-10-24 9:20 ` Amir Goldstein 2018-10-24 9:31 ` Phillip Potter 2018-10-24 9:44 ` Amir Goldstein 2018-10-24 9:56 ` Phillip Potter 2018-10-24 10:06 ` Amir Goldstein [this message] 2018-10-24 12:37 ` Al Viro 2018-10-24 13:02 ` Theodore Y. Ts'o 2018-10-24 14:41 ` Amir Goldstein 2018-10-25 11:20 ` Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAOQ4uxjJz+WLGdhW8_y715h0BRdhitUzdSAQHn74_4Xfirstname.lastname@example.org' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [RFC][PATCH v3 01/10] fs: common implementation of file type' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).