linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Upton <oupton@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	maz@kernel.org, kvmarm@lists.cs.columbia.edu,
	Jing Zhang <jingzhangos@google.com>
Subject: Re: [PATCH] KVM: ARM: count remote TLB flushes
Date: Wed, 28 Jul 2021 12:02:33 -0700	[thread overview]
Message-ID: <CAOQ_Qsg+mwmcuht=rQrqNdzaTGKgak0BQwFHzSj=9RZdK9tB5w@mail.gmail.com> (raw)
In-Reply-To: <20210727103251.16561-1-pbonzini@redhat.com>

On Tue, Jul 27, 2021 at 3:33 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> KVM/ARM has an architecture-specific implementation of
> kvm_flush_remote_tlbs; however, unlike the generic one,
> it does not count the flushes in kvm->stat.remote_tlb_flush,
> so that it inexorably remained stuck to zero.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Oliver Upton <oupton@google.com>

> ---
>  arch/arm64/kvm/mmu.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index c10207fed2f3..6cf16b43bfcc 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
> @@ -81,6 +81,7 @@ static bool memslot_is_logging(struct kvm_memory_slot *memslot)
>  void kvm_flush_remote_tlbs(struct kvm *kvm)
>  {
>         kvm_call_hyp(__kvm_tlb_flush_vmid, &kvm->arch.mmu);
> +       ++kvm->stat.generic.remote_tlb_flush;
>  }
>
>  static bool kvm_is_device_pfn(unsigned long pfn)
> --
> 2.31.1
>
> _______________________________________________
> kvmarm mailing list
> kvmarm@lists.cs.columbia.edu
> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

  reply	other threads:[~2021-07-28 19:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 10:32 Paolo Bonzini
2021-07-28 19:02 ` Oliver Upton [this message]
2021-08-02 13:45 ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ_Qsg+mwmcuht=rQrqNdzaTGKgak0BQwFHzSj=9RZdK9tB5w@mail.gmail.com' \
    --to=oupton@google.com \
    --cc=jingzhangos@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=pbonzini@redhat.com \
    --subject='Re: [PATCH] KVM: ARM: count remote TLB flushes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).