From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1339BC432BE for ; Thu, 29 Jul 2021 20:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0BE46023E for ; Thu, 29 Jul 2021 20:24:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233056AbhG2UYR (ORCPT ); Thu, 29 Jul 2021 16:24:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233085AbhG2UYJ (ORCPT ); Thu, 29 Jul 2021 16:24:09 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DFEFC0613CF for ; Thu, 29 Jul 2021 13:24:05 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id h2so13314066lfu.4 for ; Thu, 29 Jul 2021 13:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gj7yCj3TgjmiQPtQl0jHjvThrzk1CYgb/iJobvGGefk=; b=tl09esBor3zjI+pKbOaNgY4vHM/cu59XWi6upaP0j5ZXoIJjMeDMjLYtUFUsLyn+iW xo6xMo/kZo6MvUbXVq76eALXaBvUOZuBqlFleNDkQojj1DTWOmrC+aM1kCGXye8VKf1V wv5J3wu2RvdOaHyo1pFpCK9ko2I2tywWIMm0rCQ7J+cZ3Y5oZUSlXXhMXGc2XIr7/aU5 QVP8igM173wDGREtV03oDcqNYlUSnhMYfx4/tjWFc2pj3LxwDw8Zq7wrvTwvpJRi1WSE qRY+A8YZFNHyax+N2dPeGqxEchGSO2B8vG23E2kN0nYBnY/q/TEi1FkqHdqRXowpjLkx m0nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gj7yCj3TgjmiQPtQl0jHjvThrzk1CYgb/iJobvGGefk=; b=CRR4WraXUWwh+6QHmt8JOOV26zwEnvJdayMQdGpa/89hzvLUfGHcGcfoZZUf4vBd/n BnsXDU/jTi9/L0guCCIMgRUwZSjK5/Sp++BfPIsi+SmfdwWuGoRRmdTArLyEqk9Fjp0Z 3LbPKLljhaWgBLJqMKyhxNkwwOHSM6mlaSeOqu8RJFrtk5u26I8RoLm8fxTAmlZFclkp XbadRfd/lwyEk5QIecNCN8yt1hEj3SxesZp+QFMI8Ox8XJ/WMtQ9LJGWfb7M22/iqubv GMBOEYTzisa3tQOi2ch36xzFedE9IAqHfXpuQFDDNRcCmKwjj+XIZD0Y9vrrSUFHcV7p LjoQ== X-Gm-Message-State: AOAM530zUG7jZW72goZ6JmgiUI1DD0Bctvft0h6l24nNr4LFnlGYF5xz icbzRXNPGVIpqWdXbYsBhQyCBnjQT+CP5al5s4dU1g== X-Google-Smtp-Source: ABdhPJzPxiDGiDFKysX5izFriQkSlWyo919HiI1mAjdl/EIF2YA5xH+2Ix5p0VGNtGuJGYezdz59xwCBRVN47iNQNuc= X-Received: by 2002:a05:6512:3237:: with SMTP id f23mr4870368lfe.524.1627590243514; Thu, 29 Jul 2021 13:24:03 -0700 (PDT) MIME-Version: 1.0 References: <20210729195632.489978-1-oupton@google.com> <20210729195632.489978-2-oupton@google.com> In-Reply-To: From: Oliver Upton Date: Thu, 29 Jul 2021 13:23:52 -0700 Message-ID: Subject: Re: [PATCH 1/3] KVM: arm64: Record number of signal exits as a vCPU stat To: Jing Zhang Cc: KVM ARM , KVM , linux-kernel@vger.kernel.org, Paolo Bonzini , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Thomas Gleixner , Peter Zijlstra , Andy Lutomirski , linux-arm-kernel@lists.infradead.org, Peter Shier , Shakeel Butt , Guangyu Shi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 29, 2021 at 1:07 PM Jing Zhang wrote: > > On Thu, Jul 29, 2021 at 12:56 PM Oliver Upton wrote: > > > > Most other architectures that implement KVM record a statistic > > indicating the number of times a vCPU has exited due to a pending > > signal. Add support for that stat to arm64. > > > > Cc: Jing Zhang > > Signed-off-by: Oliver Upton > > --- > > arch/arm64/include/asm/kvm_host.h | 1 + > > arch/arm64/kvm/arm.c | 1 + > > arch/arm64/kvm/guest.c | 3 ++- > > 3 files changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > > index 41911585ae0c..70e129f2b574 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++ b/arch/arm64/include/asm/kvm_host.h > > @@ -576,6 +576,7 @@ struct kvm_vcpu_stat { > > u64 wfi_exit_stat; > > u64 mmio_exit_user; > > u64 mmio_exit_kernel; > > + u64 signal_exits; > > u64 exits; > > }; > > > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > > index e9a2b8f27792..60d0a546d7fd 100644 > > --- a/arch/arm64/kvm/arm.c > > +++ b/arch/arm64/kvm/arm.c > > @@ -783,6 +783,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu) > > if (signal_pending(current)) { > > ret = -EINTR; > > run->exit_reason = KVM_EXIT_INTR; > > + ++vcpu->stat.signal_exits; > > } > > > > /* > > diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c > > index 1dfb83578277..50fc16ad872f 100644 > > --- a/arch/arm64/kvm/guest.c > > +++ b/arch/arm64/kvm/guest.c > > @@ -50,7 +50,8 @@ const struct _kvm_stats_desc kvm_vcpu_stats_desc[] = { > > STATS_DESC_COUNTER(VCPU, wfi_exit_stat), > > STATS_DESC_COUNTER(VCPU, mmio_exit_user), > > STATS_DESC_COUNTER(VCPU, mmio_exit_kernel), > > - STATS_DESC_COUNTER(VCPU, exits) > > + STATS_DESC_COUNTER(VCPU, exits), > > + STATS_DESC_COUNTER(VCPU, signal_exits), > How about put signal_exits before exits as the same order in > kvm_vcpu_stat just for readability? Definitely. > > }; > > static_assert(ARRAY_SIZE(kvm_vcpu_stats_desc) == > > sizeof(struct kvm_vcpu_stat) / sizeof(u64)); > > -- > > 2.32.0.554.ge1b32706d8-goog > > > Reviewed-by: Jing Zhang Thanks Jing!