From: "Oliver O'Halloran" <oohall@gmail.com>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, Qian Cai <cai@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] powerpc/pci: unmap legacy INTx interrupts when a PHB is removed
Date: Tue, 3 Nov 2020 15:40:07 +1100 [thread overview]
Message-ID: <CAOSf1CFwsc1uqcdaF5Et7eHjZGMB0gZcwQFykkVwQR0B+PvsHw@mail.gmail.com> (raw)
In-Reply-To: <3497b725-9108-9f63-9cc2-ac7b1dd06c09@kaod.org>
On Tue, Nov 3, 2020 at 1:39 AM Cédric Le Goater <clg@kaod.org> wrote:
>
> On 10/14/20 4:55 AM, Alexey Kardashevskiy wrote:
> >
> > How do you remove PHBs exactly? There is no such thing in the powernv platform, I thought someone added this and you are fixing it but no. PHBs on powernv are created at the boot time and there is no way to remove them, you can only try removing all the bridges.
>
> yes. I noticed that later when proposing the fix for the double
> free.
>
> > So what exactly are you doing?
>
> What you just said above, with the commands :
>
> echo 1 > /sys/devices/pci0031\:00/0031\:00\:00.0/remove
> echo 1 > /sys/devices/pci0031\:00/pci_bus/0031\:00/rescan
Right, so that'll remove the root port device (and Bus 01 beneath it),
but the PHB itself is still there. If it was removed the root bus
would also disappear.
prev parent reply other threads:[~2020-11-03 4:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200807101854.844619-1-clg@kaod.org>
2020-09-23 0:33 ` [PATCH v2] powerpc/pci: unmap legacy INTx interrupts when a PHB is removed Qian Cai
2020-09-23 7:06 ` Cédric Le Goater
2020-09-24 5:11 ` Alexey Kardashevskiy
2020-09-24 10:31 ` Cédric Le Goater
2020-10-13 19:33 ` Qian Cai
2020-10-13 23:42 ` Michael Ellerman
2020-10-14 2:55 ` Alexey Kardashevskiy
2020-11-02 14:39 ` Cédric Le Goater
2020-11-03 4:40 ` Oliver O'Halloran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOSf1CFwsc1uqcdaF5Et7eHjZGMB0gZcwQFykkVwQR0B+PvsHw@mail.gmail.com \
--to=oohall@gmail.com \
--cc=aik@ozlabs.ru \
--cc=cai@redhat.com \
--cc=clg@kaod.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).