linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yu Zhao <yuzhao@google.com>
To: Liam Howlett <liam.howlett@oracle.com>
Cc: Qian Cai <quic_qiancai@quicinc.com>,
	"maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v9 28/69] mm/mmap: reorganize munmap to use maple states
Date: Wed, 15 Jun 2022 19:58:34 -0600	[thread overview]
Message-ID: <CAOUHufZtq0PDiGXBvLV=POraK-4dfnQ9UNmsafHhJmzxAhzrfw@mail.gmail.com> (raw)
In-Reply-To: <20220616014956.6jgxvbzh4ld3c32q@revolver>

On Wed, Jun 15, 2022 at 7:50 PM Liam Howlett <liam.howlett@oracle.com> wrote:
>
> * Yu Zhao <yuzhao@google.com> [220615 17:17]:
>
> ...
>
> > > Yes, I used the same parameters with 512GB of RAM, and the kernel with
> > > KASAN and other debug options.
> >
> > Sorry, Liam. I got the same crash :(
>
> Thanks for running this promptly.  I am trying to get my own server
> setup now.
>
> >
> > 9d27f2f1487a (tag: mm-everything-2022-06-14-19-05, akpm/mm-everything)
> > 00d4d7b519d6 fs/userfaultfd: Fix vma iteration in mas_for_each() loop
> > 55140693394d maple_tree: Make mas_prealloc() error checking more generic
> > 2d7e7c2fcf16 maple_tree: Fix mt_destroy_walk() on full non-leaf non-alloc nodes
> > 4d4472148ccd maple_tree: Change spanning store to work on larger trees
> > ea36bcc14c00 test_maple_tree: Add tests for preallocations and large
> > spanning writes
> > 0d2aa86ead4f mm/mlock: Drop dead code in count_mm_mlocked_page_nr()
> >
> > ==================================================================
> > BUG: KASAN: slab-out-of-bounds in mab_mas_cp+0x2d9/0x6c0
> > Write of size 136 at addr ffff88c35a3b9e80 by task stress-ng/19303
> >
> > CPU: 66 PID: 19303 Comm: stress-ng Tainted: G S        I       5.19.0-smp-DEV #1
> > Call Trace:
> >  <TASK>
> >  dump_stack_lvl+0xc5/0xf4
> >  print_address_description+0x7f/0x460
> >  print_report+0x10b/0x240
> >  ? mab_mas_cp+0x2d9/0x6c0
> >  kasan_report+0xe6/0x110
> >  ? mast_spanning_rebalance+0x2634/0x29b0
> >  ? mab_mas_cp+0x2d9/0x6c0
> >  kasan_check_range+0x2ef/0x310
> >  ? mab_mas_cp+0x2d9/0x6c0
> >  ? mab_mas_cp+0x2d9/0x6c0
> >  memcpy+0x44/0x70
> >  mab_mas_cp+0x2d9/0x6c0
> >  mas_spanning_rebalance+0x1a3e/0x4f90
>
> Does this translate to an inline around line 2997?
> And then probably around 2808?

$ ./scripts/faddr2line vmlinux mab_mas_cp+0x2d9
mab_mas_cp+0x2d9/0x6c0:
mab_mas_cp at lib/maple_tree.c:1988
$ ./scripts/faddr2line vmlinux mas_spanning_rebalance+0x1a3e
mas_spanning_rebalance+0x1a3e/0x4f90:
mast_cp_to_nodes at lib/maple_tree.c:?
(inlined by) mas_spanning_rebalance at lib/maple_tree.c:2997
$ ./scripts/faddr2line vmlinux mas_wr_spanning_store+0x16c5
mas_wr_spanning_store+0x16c5/0x1b80:
mas_wr_spanning_store at lib/maple_tree.c:?

No idea why faddr2line didn't work for the last two addresses. GDB
seems more reliable.

(gdb) li *(mab_mas_cp+0x2d9)
0xffffffff8226b049 is in mab_mas_cp (lib/maple_tree.c:1988).
(gdb) li *(mas_spanning_rebalance+0x1a3e)
0xffffffff822633ce is in mas_spanning_rebalance (lib/maple_tree.c:2801).
quit)
(gdb) li *(mas_wr_spanning_store+0x16c5)
0xffffffff8225cfb5 is in mas_wr_spanning_store (lib/maple_tree.c:4030).

  reply	other threads:[~2022-06-16  1:59 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04  0:26 [PATCH 0/1] Prepare for maple tree Liam Howlett
2022-05-04  0:26 ` [PATCH 1/1] mips: rename mt_init to mips_mt_init Liam Howlett
2022-05-12  9:54   ` David Hildenbrand
2022-05-04  1:12 ` [PATCH v9 15/69] damon: Convert __damon_va_three_regions to use the VMA iterator Liam Howlett
2022-05-10 10:44   ` SeongJae Park
2022-05-10 16:27     ` Liam Howlett
2022-05-10 19:13     ` Andrew Morton
2022-05-04  1:13 ` [PATCH v9 16/69] proc: remove VMA rbtree use from nommu Liam Howlett
2022-05-04  1:13   ` [PATCH v9 17/69] mm: remove rb tree Liam Howlett
2022-05-04  1:13   ` [PATCH v9 19/69] xen: use vma_lookup() in privcmd_ioctl_mmap() Liam Howlett
2022-05-04  1:13   ` [PATCH v9 20/69] mm: optimize find_exact_vma() to use vma_lookup() Liam Howlett
2022-05-04  1:13   ` [PATCH v9 18/69] mmap: change zeroing of maple tree in __vma_adjust() Liam Howlett
2022-05-04  1:13   ` [PATCH v9 23/69] mm: use maple tree operations for find_vma_intersection() Liam Howlett
2022-05-04  1:13   ` [PATCH v9 21/69] mm/khugepaged: optimize collapse_pte_mapped_thp() by using vma_lookup() Liam Howlett
2022-05-04  1:13   ` [PATCH v9 22/69] mm/mmap: change do_brk_flags() to expand existing VMA and add do_brk_munmap() Liam Howlett
2022-05-04  1:13   ` [PATCH v9 24/69] mm/mmap: use advanced maple tree API for mmap_region() Liam Howlett
2022-05-04  1:13   ` [PATCH v9 25/69] mm: remove vmacache Liam Howlett
2022-05-04  1:13   ` [PATCH v9 27/69] mm/mmap: move mmap_region() below do_munmap() Liam Howlett
2022-05-04  1:13   ` [PATCH v9 26/69] mm: convert vma_lookup() to use mtree_load() Liam Howlett
2022-05-04  1:13   ` [PATCH v9 28/69] mm/mmap: reorganize munmap to use maple states Liam Howlett
2022-06-06 12:09     ` Qian Cai
2022-06-06 16:19       ` Liam Howlett
2022-06-06 16:40         ` Qian Cai
2022-06-11 20:11           ` Yu Zhao
2022-06-11 21:49             ` Yu Zhao
2022-06-12  1:09               ` Liam Howlett
2022-06-15 14:25               ` Liam Howlett
2022-06-15 18:07                 ` Yu Zhao
2022-06-15 18:55                   ` Liam Howlett
2022-06-15 19:05                     ` Yu Zhao
2022-06-15 21:16                       ` Yu Zhao
2022-06-16  1:50                         ` Liam Howlett
2022-06-16  1:58                           ` Yu Zhao [this message]
2022-06-16  2:56                             ` Liam Howlett
2022-06-16  3:02                               ` Yu Zhao
2022-06-16  5:45                                 ` Yu Zhao
2022-06-16  5:55                                   ` Yu Zhao
2022-06-16 18:26                                     ` Liam Howlett
2022-06-16 18:34                                       ` Yu Zhao
2022-06-17 13:49                                         ` Liam Howlett
2022-05-04  1:13   ` [PATCH v9 29/69] mm/mmap: change do_brk_munmap() to use do_mas_align_munmap() Liam Howlett
2022-05-04  1:13   ` [PATCH v9 30/69] arm64: remove mmap linked list from vdso Liam Howlett
2022-05-04  1:13   ` [PATCH v9 31/69] arm64: Change elfcore for_each_mte_vma() to use VMA iterator Liam Howlett
2022-05-04  1:13   ` [PATCH v9 33/69] powerpc: remove mmap linked list walks Liam Howlett
2022-05-04  1:13   ` [PATCH v9 32/69] parisc: remove mmap linked list from cache handling Liam Howlett
2022-05-04  1:13   ` [PATCH v9 35/69] x86: remove vma linked list walks Liam Howlett
2022-05-04  1:13   ` [PATCH v9 36/69] xtensa: " Liam Howlett
2022-05-04  1:13   ` [PATCH v9 34/69] s390: " Liam Howlett
2022-05-04  1:13   ` [PATCH v9 38/69] optee: remove vma linked list walk Liam Howlett
2022-05-04  1:13   ` [PATCH v9 39/69] um: " Liam Howlett
2022-05-04  1:13   ` [PATCH v9 37/69] cxl: " Liam Howlett
2022-05-04  1:13   ` [PATCH v9 40/69] coredump: " Liam Howlett
2022-05-04  1:13   ` [PATCH v9 41/69] exec: use VMA iterator instead of linked list Liam Howlett
2022-05-04  1:13   ` [PATCH v9 42/69] fs/proc/base: use maple tree iterators in place " Liam Howlett
2022-05-04  1:13   ` [PATCH v9 43/69] fs/proc/task_mmu: stop using linked list and highest_vm_end Liam Howlett
2022-05-04  1:13   ` [PATCH v9 45/69] ipc/shm: use VMA iterator instead of linked list Liam Howlett
2022-05-04  1:13   ` [PATCH v9 44/69] userfaultfd: use maple tree iterator to iterate VMAs Liam Howlett
2022-05-04  1:14   ` [PATCH v9 47/69] perf: use VMA iterator Liam Howlett
2022-05-04  1:14   ` [PATCH v9 46/69] acct: use VMA iterator instead of linked list Liam Howlett
2022-05-04  1:14   ` [PATCH v9 48/69] sched: use maple tree iterator to walk VMAs Liam Howlett
2022-05-04  1:14   ` [PATCH v9 50/69] bpf: remove VMA linked list Liam Howlett
2022-05-04  1:14   ` [PATCH v9 49/69] fork: use VMA iterator Liam Howlett
2022-05-04  1:14   ` [PATCH v9 52/69] mm/khugepaged: stop using vma linked list Liam Howlett
2022-05-04  1:14   ` [PATCH v9 51/69] mm/gup: use maple tree navigation instead of " Liam Howlett
2022-05-04  1:14   ` [PATCH v9 53/69] mm/ksm: use vma iterators instead of vma " Liam Howlett
2022-05-04  1:14   ` [PATCH v9 54/69] mm/madvise: use vma_find() " Liam Howlett
2022-05-04  1:14   ` [PATCH v9 55/69] mm/memcontrol: stop using mm->highest_vm_end Liam Howlett
2022-05-04  1:14   ` [PATCH v9 56/69] mm/mempolicy: use vma iterator & maple state instead of vma linked list Liam Howlett
2022-05-04  1:14   ` [PATCH v9 59/69] mm/mremap: use vma_find_intersection() " Liam Howlett
2022-05-04  1:14   ` [PATCH v9 57/69] mm/mlock: use vma iterator and maple state " Liam Howlett
2022-05-04  1:14   ` [PATCH v9 58/69] mm/mprotect: use maple tree navigation " Liam Howlett
2022-05-04  1:14   ` [PATCH v9 60/69] mm/msync: use vma_find() " Liam Howlett
2022-05-04  1:14   ` [PATCH v9 61/69] mm/oom_kill: use maple tree iterators " Liam Howlett
2022-05-04  1:14   ` [PATCH v9 62/69] mm/pagewalk: use vma_find() " Liam Howlett
2022-05-04  1:14   ` [PATCH v9 63/69] mm/swapfile: use vma iterator " Liam Howlett
2022-05-04  1:14   ` [PATCH v9 65/69] nommu: remove uses of VMA " Liam Howlett
2022-05-04  1:14   ` [PATCH v9 64/69] i915: use the VMA iterator Liam Howlett
2022-05-04  1:14   ` [PATCH v9 66/69] riscv: use vma iterator for vdso Liam Howlett
2022-05-04  1:14   ` [PATCH v9 68/69] mm/mmap: drop range_has_overlap() function Liam Howlett
2022-05-04  1:14   ` [PATCH v9 67/69] mm: remove the vma linked list Liam Howlett
2022-05-13 13:30     ` Qian Cai
2022-05-13 14:17       ` Liam Howlett
2022-05-04  1:14   ` [PATCH v9 69/69] mm/mmap.c: pass in mapping to __vma_link_file() Liam Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOUHufZtq0PDiGXBvLV=POraK-4dfnQ9UNmsafHhJmzxAhzrfw@mail.gmail.com' \
    --to=yuzhao@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=liam.howlett@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=quic_qiancai@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).