From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933228AbcFPCgV (ORCPT ); Wed, 15 Jun 2016 22:36:21 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:37697 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932346AbcFPCgT (ORCPT ); Wed, 15 Jun 2016 22:36:19 -0400 MIME-Version: 1.0 In-Reply-To: References: <1465807339-1100-1-git-send-email-zhengxing@rock-chips.com> <20160614223810.GA7925@rob-hp-laptop> <20160615095312.GY2282@sirena.org.uk> From: Ben Zhang Date: Wed, 15 Jun 2016 19:36:17 -0700 X-Google-Sender-Auth: s5_7tqbzFxgmR27wqcDiCpk4Dyk Message-ID: Subject: Re: [alsa-devel] [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards To: Mark Brown Cc: Rob Herring , Mark Rutland , "devicetree@vger.kernel.org" , Linux-ALSA , Xing Zheng , Pawel Moll , Ian Campbell , "linux-kernel@vger.kernel.org" , Takashi Iwai , Doug Anderson , Liam Girdwood , "open list:ARM/Rockchip SoC..." , Kumar Gala , "linux-arm-kernel@lists.infradead.org" , =?UTF-8?Q?Heiko_St=C3=BCbner?= , smbarber@chromium.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2016 at 5:44 AM, Rob Herring wrote: > On Wed, Jun 15, 2016 at 4:53 AM, Mark Brown wrote: >> On Tue, Jun 14, 2016 at 05:38:10PM -0500, Rob Herring wrote: >>> On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote: >> >>> > +sound { >>> > + compatible = "rockchip,rk3399-gru-sound"; >>> > + rockchip,cpu = <&i2s0>; >>> > + rockchip,codec = <&max98357a &rt5514 &da7219>; >> >>> These seem fairly standard though a variety of versions in the bindings. >>> Can we use audio-codec and audio-cpu (or cpu or audio-dai) here? Mark? >> >> Well, the roles aren't actually that standard (the fact that there's >> multiple CODECs and one CPU DAI here is really odd and definitely needs >> a very system specific interpretation). If they were standard we >> already have the simple-card binding that things should be using. >> There's no point in standard property names if the interpretation has to >> be non-standard. > > Okay, I agree with the system specific interpretation part. However, I > don't think using simple-card or not determines using common > properties. > Hi Mark, I have a question for the one CPU DAI + multiple CODECs setup. The machine driver defines 3 DAI links, connecting the same CPU DAI to 3 different CODEC DAIs. Does ASoC/DAPM support enabling/disabling an individual DAI link based on the status of the endpoint widget (e.g. DAPM_SPK) connected to the corresponding CODEC? The goal is to let user select either headphone(da7219) or speaker(max98357a) as output. max98357a driver does not expose a kcontrol for mute. It sets a shutdown GPIO on PCM_TRIGGER_START/STOP. And it seems soc_pcm_trigger calls the trigger op of all 3 CODEC DAIs, even when the DAPM_SPK widget is disabled by its pin switch. >> The vendor specific prefixes are there because all bindings are supposed >> to add prefixes to property names. > > ...unless they are common. > > Rob > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel Thanks, Ben