From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 234BCC433EF for ; Tue, 7 Jun 2022 12:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244090AbiFGMm6 (ORCPT ); Tue, 7 Jun 2022 08:42:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244081AbiFGMmw (ORCPT ); Tue, 7 Jun 2022 08:42:52 -0400 Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78F671C93D for ; Tue, 7 Jun 2022 05:42:50 -0700 (PDT) Received: by mail-qv1-xf31.google.com with SMTP id i19so12212587qvu.13 for ; Tue, 07 Jun 2022 05:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=KCA+Y9dgW4Jgevx79kF7IXZRJWrbeJFPviDARnJw5Mc=; b=qknqJjglN56ohEAbFyDfNeXUIP9FeORmYBmG/najnECYVQ6aERWwK3uNx/5aLZaH9V 6DpOhAFl9r19IYVWnRXrEpmoW3D5UkDfBp8DcWHy8dD4QVPHDpW+B4/YSvcG/JoIiitm BUx7m4W+baMryknlVA4UPqRxIluniQ0hlMWfK08uVWpWTaxHcGUVagzJwo7lWcOhA8En 1n5+rwoecE7EbguzW7fmGpz7Jh+bIpbuy1uy8qWQbg0ovwXMykXX3WEv06Tu7F9Osngq og1oAM8PvbTalUVyhQH1hMeb84cKkT80sO37aXhLSrDn9WCTrjFcS4umI1E7zm+K/sRk J2vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=KCA+Y9dgW4Jgevx79kF7IXZRJWrbeJFPviDARnJw5Mc=; b=hTVCC/CGRaQS7nHFnWy5aimSVZ92UirZa88h1tlAn1Ap/a9H0JfISS29pX2LAnUJRU ap+2D5hWYjxz6LdSuMJ+wuvtwrgjoXLhoE+aI72JUHteCXL3rv0ySmiLwaXtVpFWZrTR BHkyu13RZXa3jWFEIVqBhuYQS8tCdkmhpzD/zek4IgJ0maKqaYxaU07xUoTV6ermF4jh Gb3Isp1Q8yi1WX4XVYR9kzQ5YDHP31I853TUyZ0bJ8d8vDVFwzjsoE254L+AWARcDd2M qIspocNJvXFqbLapL9X5DZSLAIhTcUKjYqClQDqlr07yyfUwk2HZ8pSwVn3jNxate+Rq a5Ww== X-Gm-Message-State: AOAM530qbWhAhvaEq1m8xghgAOHtRO1GtpmFm5YnqF11eQU95Bh3J3gl GgE5outsf3jHTKb47MD3cqySAPWBkgZ87ZE8Lac= X-Google-Smtp-Source: ABdhPJzURX7nJxppBGO7nDeeb8f3GP7bnqNS72VUGNXWWCu86vAljqYLzZLTtFNKiAx/tprPSJr3CHJUCQnf5FDThVg= X-Received: by 2002:a05:6214:2422:b0:467:d777:7cda with SMTP id gy2-20020a056214242200b00467d7777cdamr17957263qvb.118.1654605769540; Tue, 07 Jun 2022 05:42:49 -0700 (PDT) MIME-Version: 1.0 References: <20220604145624.47326-1-robimarko@gmail.com> In-Reply-To: From: Robert Marko Date: Tue, 7 Jun 2022 14:42:38 +0200 Message-ID: Subject: Re: [PATCH 1/3] regulator: mp5416: alphabetically sort header includes To: Christophe JAILLET Cc: sravanhome@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 4 Jun 2022 at 17:41, Christophe JAILLET wrote: > > Le 04/06/2022 =C3=A0 16:56, Robert Marko a =C3=A9crit : > > Sort the header include list alphabetically. > > > > Signed-off-by: Robert Marko > > --- > > drivers/regulator/mp5416.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/regulator/mp5416.c b/drivers/regulator/mp5416.c > > index 39cebec0edb6..d8245080df03 100644 > > --- a/drivers/regulator/mp5416.c > > +++ b/drivers/regulator/mp5416.c > > @@ -6,14 +6,14 @@ > > // > > // Author: Saravanan Sekar > > > > +#include > > +#include > > +#include > > #include > > Nitpick: it seems that kernel.h is not needed here. (at least it compile > without it). Hi, It also seems to work fine without it, will send a patch to remove it. Regards, Robert > > CJ > > > #include > > -#include > > -#include > > #include > > #include > > #include > > -#include > > > > #define MP5416_REG_CTL0 0x00 > > #define MP5416_REG_CTL1 0x01 >