From: Timur Tabi <timur@codeaurora.org>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Linus <linus.walleij@linaro.org>,
Grant Likely <grant.likely@secretlab.ca>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/1] pinctrl: add Intel BayTrail GPIO/pinctrl support
Date: Fri, 11 Apr 2014 17:54:56 -0500 [thread overview]
Message-ID: <CAOZdJXU2hN+9TE=XN55TZF_W-0hxHZmK5330i6hwrhOERKFetw@mail.gmail.com> (raw)
In-Reply-To: <1371555182-12418-2-git-send-email-mathias.nyman@linux.intel.com>
On Tue, Jun 18, 2013 at 6:33 AM, Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:
>
> Pins may be muxed to alternate function instead of gpio by firmware.
> This driver does not touch the pin muxing and expect firmare
> to set pin muxing and pullup/down properties properly.
>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> ---
> drivers/pinctrl/Kconfig | 12 +
> drivers/pinctrl/Makefile | 1 +
> drivers/pinctrl/pinctrl-baytrail.c | 543 ++++++++++++++++++++++++++++++++++++
I know it's been ten months since you posted this driver, but I have a
question. If this driver does not touch the pin muxing, and it
doesn't even call pinctrl_register(), then why is it in
drivers/pinctrl? It's not a pinctrl driver. Why isn't this a regular
GPIO drivers in drivers/gpio?
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
next prev parent reply other threads:[~2014-04-11 22:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 11:33 [PATCH v3 0/1] Pinctrl/gpio driver for Intel Baytrail platforms Mathias Nyman
2013-06-18 11:33 ` [PATCH v3 1/1] pinctrl: add Intel BayTrail GPIO/pinctrl support Mathias Nyman
2013-06-18 15:17 ` Linus Walleij
2013-06-19 10:28 ` Mathias Nyman
2014-04-11 22:54 ` Timur Tabi [this message]
2014-04-14 7:52 ` Mathias Nyman
2014-04-14 15:11 ` Timur Tabi
2014-04-15 10:01 ` Mathias Nyman
2014-04-17 16:47 ` Timur Tabi
2014-04-23 11:46 ` Mathias Nyman
2014-04-23 12:07 ` Timur Tabi
2014-04-23 13:59 ` Westerberg, Mika
2014-04-23 15:14 ` Timur Tabi
2014-04-23 22:20 ` Linus Walleij
2014-04-23 22:54 ` Timur Tabi
2014-04-24 6:27 ` Westerberg, Mika
2014-04-24 11:20 ` Timur Tabi
2014-04-24 11:38 ` Westerberg, Mika
2014-04-24 6:35 ` Westerberg, Mika
2014-04-24 11:18 ` Timur Tabi
2014-04-24 11:58 ` Westerberg, Mika
2014-04-24 13:29 ` Linus Walleij
2014-04-24 15:25 ` Timur Tabi
2014-04-25 7:41 ` Westerberg, Mika
2014-04-25 10:36 ` Linus Walleij
2014-04-25 16:13 ` Timur Tabi
2014-04-25 16:21 ` Rafael J. Wysocki
2014-04-25 16:31 ` Timur Tabi
2014-05-02 22:31 ` Linus Walleij
2014-04-23 22:17 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOZdJXU2hN+9TE=XN55TZF_W-0hxHZmK5330i6hwrhOERKFetw@mail.gmail.com' \
--to=timur@codeaurora.org \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).