From: Timur Tabi <timur@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
PowerPC Mailing List <linuxppc-dev@lists.ozlabs.org>,
alsa-devel mailing list <alsa-devel@alsa-project.org>,
timur@kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH -next 9/9] ASoC: fsl_xcvr: check return value after calling platform_get_resource_byname()
Date: Sun, 13 Jun 2021 09:00:25 -0500 [thread overview]
Message-ID: <CAOZdJXUn9FgdhiPAqbxMrz4tSeqQ_S+L9jkpg48NxCo5Fz7PXQ@mail.gmail.com> (raw)
In-Reply-To: <20210611093626.579176-10-yangyingliang@huawei.com>
On Fri, Jun 11, 2021 at 4:32 AM Yang Yingliang <yangyingliang@huawei.com> wrote:
> rx_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rxfifo");
> tx_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "txfifo");
> + if (!rx_res || !tx_res) {
> + dev_err(dev, "Invalid resource\n");
> + return -EINVAL;
> + }
If platform_get_resource_byname() returns an error, it's probably
because the name cannot be found. So I think this error message is
more accurate:
"could not find rxfifo or txfifo resource"
prev parent reply other threads:[~2021-06-13 14:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 9:36 [PATCH -next 0/9] ASoC: fsl: Use devm_platform_get_and_ioremap_resource() Yang Yingliang
2021-06-11 9:36 ` [PATCH -next 1/9] ASoC: fsl_asrc: " Yang Yingliang
2021-06-11 9:36 ` [PATCH -next 2/9] ASoC: fsl_aud2htx: " Yang Yingliang
2021-06-11 9:36 ` [PATCH -next 3/9] ASoC: fsl_easrc: " Yang Yingliang
2021-06-11 9:36 ` [PATCH -next 4/9] ASoC: fsl_esai: " Yang Yingliang
2021-06-11 9:36 ` [PATCH -next 5/9] ASoC: fsl_micfil: " Yang Yingliang
2021-06-11 9:36 ` [PATCH -next 6/9] ASoC: fsl_sai: " Yang Yingliang
2021-06-11 9:36 ` [PATCH -next 7/9] ASoC: fsl_spdif: " Yang Yingliang
2021-06-11 9:36 ` [PATCH -next 8/9] ASoC: fsl_ssi: " Yang Yingliang
2021-06-11 9:36 ` [PATCH -next 9/9] ASoC: fsl_xcvr: check return value after calling platform_get_resource_byname() Yang Yingliang
2021-06-13 14:00 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOZdJXUn9FgdhiPAqbxMrz4tSeqQ_S+L9jkpg48NxCo5Fz7PXQ@mail.gmail.com \
--to=timur@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).