From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50002C0018C for ; Wed, 16 Dec 2020 17:58:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C9C124BC1 for ; Wed, 16 Dec 2020 17:58:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728614AbgLPR6d (ORCPT ); Wed, 16 Dec 2020 12:58:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728609AbgLPR6c (ORCPT ); Wed, 16 Dec 2020 12:58:32 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ACD5C06179C for ; Wed, 16 Dec 2020 09:57:51 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id s26so15908690lfc.8 for ; Wed, 16 Dec 2020 09:57:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3ZAA26HLG36Xvu0N7Lw9uUcJ1NvzFfW1dGKLX9h8st0=; b=JCF0T0BdODPAh9sgJ0Dbubl6gNI0wTOnfeA1T8bbhNeo4Vdg0ZcFBOsPWNhOsF0Nrb 1uxgjazlpeN28DWB8onxe+uttiZ4WdgiQF/Z/hkz0JVHGKR8LveLBh3U6msHCD6KzhAE Kpo+GSw98uqa7eMuQ4zw7Bkai/n2qV0oPMn3ACiMf9UFrVlUv47zskfzOpBbKST+Tg2i xA6/UXlcrTrl3Xj7jEzqmU9/zq4GX81slNt0zdoGXz2DGwVxjt1rz7o+fOTdcHpstuB+ l8kcyn+4nf19fOG7jXArN0uKS+OAoyWkx28Qo1ZNAQzARyAPJj1YgL1Slows/ghyHmNU 13fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3ZAA26HLG36Xvu0N7Lw9uUcJ1NvzFfW1dGKLX9h8st0=; b=CL8hW/HaeN/Vk0wksTEmObP3N1oAoeQ6nDGWcvLlZbD5/NqhTl78BhaivC5+D0B4ng pB6nbVh31gCJA7JjoBEY5sdVcqlb7taTzwDVr81194WMvbQ5HIMPq20OvZ32hu/BCiSp fXlcTM2ntAA4G3gZ4Jy62KPF/gJnVK/aSBjX7jyDmzmJuosH2BzDUeg9MDbrfsnEuZwS SIgMm7I+A7JRxywtLkd0w/zrZBzsEOtKsHGljQ4VSz2HxuRuOvi9IN53t7D3a/ba/WUc 6NhiQxKQSM9xPUJ4GHh9b92QPfDQUEC3ne6rO6YvF3+KrtGIJ59eFO9i15EzkX6/te31 olFw== X-Gm-Message-State: AOAM530GDt/qaVAvLUQD9aYQtpVQcTNBc8CpbaaTy3dIcxHcy3yNPAv0 MKm+FhNbKjTpGoa6w79zv8xepcdCfQw9fgKJpITRFQ== X-Google-Smtp-Source: ABdhPJw5c3OCJIuoNhHcuvnrQn7/ICbS3gk2kd2nIfl23ui/Q3VovlTktYiHjFn9OPyAOKgVVUNg5KEldFqYcRrHNvQ= X-Received: by 2002:a19:8c8:: with SMTP id 191mr12977544lfi.492.1608141469335; Wed, 16 Dec 2020 09:57:49 -0800 (PST) MIME-Version: 1.0 References: <20201215235334.GA227480@roeck-us.net> <20201216004931.113505-1-john.stultz@linaro.org> In-Reply-To: <20201216004931.113505-1-john.stultz@linaro.org> From: Sumit Semwal Date: Wed, 16 Dec 2020 23:27:37 +0530 Message-ID: Subject: Re: [PATCH] dma-buf: cma_heap: Include linux/vmalloc.h to fix build failures on MIPS To: John Stultz Cc: lkml , Liam Mark , Laura Abbott , Brian Starkey , Hridya Valsaraju , Suren Baghdasaryan , Sandeep Patil , Daniel Mentz , Chris Goldsworthy , =?UTF-8?Q?=C3=98rjan_Eide?= , Robin Murphy , Ezequiel Garcia , Simon Ser , James Jones , "open list:DMA BUFFER SHARING FRAMEWORK" , DRI mailing list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, On Wed, 16 Dec 2020 at 06:19, John Stultz wrote: > > We need to include in order for MIPS to find > vmap(), as it doesn't otherwise get included there. > > Without this patch, one can hit the following build error: > drivers/dma-buf/heaps/cma_heap.c: In function 'cma_heap_do_vmap': > drivers/dma-buf/heaps/cma_heap.c:195:10: error: implicit declaration of= function 'vmap' Thanks for the patch; I've merged it to drm-misc-next-fixes. > > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Hridya Valsaraju > Cc: Suren Baghdasaryan > Cc: Sandeep Patil > Cc: Daniel Mentz > Cc: Chris Goldsworthy > Cc: =C3=98rjan Eide > Cc: Robin Murphy > Cc: Ezequiel Garcia > Cc: Simon Ser > Cc: James Jones > Cc: linux-media@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Fixes: a5d2d29e24be ("dma-buf: heaps: Move heap-helper logic into the cma= _heap implementation") > Reported-by: Guenter Roeck > Signed-off-by: John Stultz > --- > drivers/dma-buf/heaps/cma_heap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma= _heap.c > index 5e7c3436310c..3c4e34301172 100644 > --- a/drivers/dma-buf/heaps/cma_heap.c > +++ b/drivers/dma-buf/heaps/cma_heap.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > > > struct cma_heap { > -- > 2.17.1 > Best, Sumit.