From: Sumit Semwal <sumit.semwal@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: agross@kernel.org, lgirdwood@gmail.com,
Mark Brown <broonie@kernel.org>,
robh+dt@kernel.org, Nisha Kumari <nishakumari@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, kgunda@codeaurora.org,
Rajendra Nayak <rnayak@codeaurora.org>
Subject: Re: [v2 1/4] dt-bindings: regulator: Add labibb regulator
Date: Thu, 14 May 2020 17:20:06 +0530 [thread overview]
Message-ID: <CAO_48GHHhP+gRnEfeXeGob5Q4150oQOtWEyx8Fz5rFiUqXYa4A@mail.gmail.com> (raw)
In-Reply-To: <20200512014339.GE57962@builder.lan>
Hello Bjorn,
Thanks for the comments!
On Tue, 12 May 2020 at 07:15, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Fri 08 May 13:41 PDT 2020, Sumit Semwal wrote:
>
> > From: Nisha Kumari <nishakumari@codeaurora.org>
> >
> > Adding the devicetree binding for labibb regulator.
> >
> > Signed-off-by: Nisha Kumari <nishakumari@codeaurora.org>
> > Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
>
> Sorry, I missed this when we talked about it. But please rewrite this in
> yaml.
Sure, I will.
>
> >
> > --
> > v2: updated for better compatible string and names.
> > ---
> > .../regulator/qcom-labibb-regulator.txt | 47 +++++++++++++++++++
> > 1 file changed, 47 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.txt
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.txt b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.txt
> > new file mode 100644
> > index 000000000000..6e639d69f780
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.txt
> > @@ -0,0 +1,47 @@
> > +Qualcomm's LAB(LCD AMOLED Boost)/IBB(Inverting Buck Boost) Regulator
> > +
> > +LAB can be used as a positive boost power supply and IBB can be used as a negative
> > +boost power supply for display panels. Currently implemented for pmi8998.
> > +
> > +Main node required properties:
> > +
> > +- compatible: Must be:
> > + "qcom,pmi8998-lab-ibb"
> > +- #address-cells: Must be 1
> > +- #size-cells: Must be 0
>
> But the children doesn't have reg properties...
Oh, right. Let me correct that.
>
> > +
> > +LAB subnode required properties:
> > +
> > +- interrupts: Specify the interrupts as per the interrupt
> > + encoding.
> > +- interrupt-names: Interrupt names to match up 1-to-1 with
> > + the interrupts specified in 'interrupts'
> > + property.
>
> Do specify the expected string (and given that you already have the
> lab & ibb subnodes, you don't need to include this in the string).
Yes, agreed. Keeping it as 'sc-err' makes the code easier too.
>
> Regards,
> Bjorn
Best,
Sumit.
>
> > +
> > +IBB subnode required properties:
> > +
> > +- interrupts: Specify the interrupts as per the interrupt
> > + encoding.
> > +- interrupt-names: Interrupt names to match up 1-to-1 with
> > + the interrupts specified in 'interrupts'
> > + property.
> > +
> > +Example:
> > + pmi8998_lsid1: pmic@3 {
> > + labibb {
> > + compatible = "qcom,pmi8998-lab-ibb";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + lab: lab {
> > + interrupts = <0x3 0xde 0x0 IRQ_TYPE_EDGE_RISING>;
> > + interrupt-names = "lab-sc-err";
> > + };
> > +
> > + ibb: ibb {
> > + interrupts = <0x3 0xdc 0x2 IRQ_TYPE_EDGE_RISING>;
> > + interrupt-names = "ibb-sc-err";
> > + };
> > +
> > + };
> > + };
> > --
> > 2.26.2
> >
next prev parent reply other threads:[~2020-05-14 11:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 20:41 [v2 0/4] Qualcomm labibb regulator driver Sumit Semwal
2020-05-08 20:41 ` [v2 1/4] dt-bindings: regulator: Add labibb regulator Sumit Semwal
2020-05-12 1:43 ` Bjorn Andersson
2020-05-14 11:50 ` Sumit Semwal [this message]
2020-05-08 20:41 ` [v2 2/4] arm64: dts: qcom: pmi8998: Add nodes for LAB and IBB regulators Sumit Semwal
2020-05-08 20:41 ` [v2 3/4] regulator: qcom: Add labibb driver Sumit Semwal
2020-05-11 10:39 ` Mark Brown
2020-05-14 11:27 ` Sumit Semwal
2020-05-27 16:31 ` Sumit Semwal
2020-05-27 16:39 ` Mark Brown
2020-05-12 2:15 ` Bjorn Andersson
2020-05-12 11:44 ` Mark Brown
2020-05-14 11:47 ` Sumit Semwal
2020-05-08 20:42 ` [v2 4/4] regulator: qcom: labibb: Add SC interrupt handling Sumit Semwal
2020-05-11 10:49 ` Mark Brown
2020-05-14 11:50 ` Sumit Semwal
2020-05-12 5:25 ` Bjorn Andersson
2020-05-14 11:58 ` Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO_48GHHhP+gRnEfeXeGob5Q4150oQOtWEyx8Fz5rFiUqXYa4A@mail.gmail.com \
--to=sumit.semwal@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nishakumari@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).