From: Michael Ira Krufky <mkrufky@linuxtv.org>
To: zhongjiang@huawei.com
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Brad Love <brad@nextdimension.cc>,
linux-media <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: dvb-frontends: Use kmemdup instead of duplicating its function
Date: Tue, 18 Sep 2018 15:58:33 -0400 [thread overview]
Message-ID: <CAOcJUbzfv8DLpRAbAiodqDDQ5wH1uyqjJ-sKN+qJGr=xagQBNg@mail.gmail.com> (raw)
In-Reply-To: <1537284628-62020-1-git-send-email-zhongjiang@huawei.com>
On Tue, Sep 18, 2018 at 11:42 AM zhong jiang <zhongjiang@huawei.com> wrote:
>
> kmemdup has implemented the function that kmalloc() + memcpy().
> We prefer to kmemdup rather than code opened implementation.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/media/dvb-frontends/lgdt3306a.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c
> index 0e1f5da..abec2e5 100644
> --- a/drivers/media/dvb-frontends/lgdt3306a.c
> +++ b/drivers/media/dvb-frontends/lgdt3306a.c
> @@ -2205,15 +2205,13 @@ static int lgdt3306a_probe(struct i2c_client *client,
> struct dvb_frontend *fe;
> int ret;
>
> - config = kzalloc(sizeof(struct lgdt3306a_config), GFP_KERNEL);
> + onfig = kmemdup(client->dev.platform_data,
> + sizeof(struct lgdt3306a_config), GFP_KERNEL);
> if (config == NULL) {
> ret = -ENOMEM;
> goto fail;
> }
>
> - memcpy(config, client->dev.platform_data,
> - sizeof(struct lgdt3306a_config));
> -
> config->i2c_addr = client->addr;
> fe = lgdt3306a_attach(config, client->adapter);
> if (fe == NULL) {
Thank you for this patch, Zhong. I suspect, however, that the patch
might contain a typo. It looks like the `c` got dropped off of the
`config` variable.
Did you test this before sending it in?
Thanks again and best regards,
Michael Krufky
next prev parent reply other threads:[~2018-09-18 19:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 15:30 [PATCH] media: dvb-frontends: Use kmemdup instead of duplicating its function zhong jiang
2018-09-18 19:58 ` Michael Ira Krufky [this message]
2018-09-19 1:30 ` zhong jiang
2018-09-18 22:51 ` kbuild test robot
2018-09-19 0:52 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOcJUbzfv8DLpRAbAiodqDDQ5wH1uyqjJ-sKN+qJGr=xagQBNg@mail.gmail.com' \
--to=mkrufky@linuxtv.org \
--cc=brad@nextdimension.cc \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).