From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD1BCC433E0 for ; Mon, 18 Jan 2021 02:05:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A15A5224DF for ; Mon, 18 Jan 2021 02:05:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730878AbhARCEo (ORCPT ); Sun, 17 Jan 2021 21:04:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730175AbhARCEf (ORCPT ); Sun, 17 Jan 2021 21:04:35 -0500 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58F3EC061573 for ; Sun, 17 Jan 2021 18:03:55 -0800 (PST) Received: by mail-io1-xd29.google.com with SMTP id x21so11767052iog.10 for ; Sun, 17 Jan 2021 18:03:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O3vR2z56Ju8deovQ5OzdEqwpGVdMnT5d3k23oCPpdpE=; b=w1ucSC4CsfArGDDmu/srEDmwi4U/Dw9W+lSlM9i1iNZ1ZKybUTK/XiJ/5JyoEnLEUs dS+LJLuWDL4iWDzIY0g0GseCY0wBM6Noe3noRHom0GgjuTT3996zAGxplwRij9gSjMhN v8sAdyCCxmEulp0ONSL5y4czlsC1L7GAOgHRJMw3HHAeX455xzWCUNV0U9HaBngDcfpJ jqfwO5rnPJc2/vQhT4KC8/JCFlUqgEQkX0A+mNwJpsnCqfLbgYNvJUtaKCehSZSB40n0 Qk7ijENbiLCrUbysUNMtn0aqFhERqftlqYQkjlf8zxXNUMh9aAqHBdJSXqhZhihnGVqC 41/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O3vR2z56Ju8deovQ5OzdEqwpGVdMnT5d3k23oCPpdpE=; b=Hl+DyHBgxrs4vq7nuIiZmQOeHKWmOsg7D++WSxQ/SHg+EIBwtxXqD+/ymuHtxgnAQi eVp3OQG09YQWlbZz4AbFlEyI7OIfs09/LrXaQ8l1zLZwvK8WgW4ofGeSA5eawh+BHz9q WEeEJDllGKWXYhNrKewZ1Y9x1Jwqx+69MCSLkK1FriLGVHBCbWvN61xjc8MkvCuYNm+p sg+iKX70d66J2Pg1CCyBAlnnUNFPBI2OFCIffU+CUbMdVnlpayhqAA5V2DLrqn7SGqWB vmZBniAyHDPJtgfQhBr4qWfZ9k6AP3Xkle3TsjJkPAVvwCAjliECTrHhH4GN+AV0pT7F bubw== X-Gm-Message-State: AOAM530kIa0Meky0ej3HDEBL2xjK4MupdXKn2PjR3zCyLGRtAc+A8sUX rZuIeswOh1oLOXzmZt8d/t2hvuHbNky93lFcRs/BCg== X-Google-Smtp-Source: ABdhPJwSC3CvfhYeFLcOwiQWyegVKqrUVeIKDA2mn4F/hw/vHFHUgiYddoussLLbP3atey+SsTKNy8OahClOEOWsGVM= X-Received: by 2002:a5d:940d:: with SMTP id v13mr1251502ion.193.1610935434645; Sun, 17 Jan 2021 18:03:54 -0800 (PST) MIME-Version: 1.0 References: <20210117035140.1437-1-alistair@alistair23.me> <20210117035140.1437-2-alistair@alistair23.me> In-Reply-To: From: Olof Johansson Date: Sun, 17 Jan 2021 18:03:43 -0800 Message-ID: Subject: Re: [PATCH 2/2] remarkable2_defconfig: Add initial support for the reMarkable2 To: Alistair Francis Cc: Alistair Francis , Arnd Bergmann , Rob Herring , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Linux ARM Mailing List , DTML , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sun, Jan 17, 2021 at 5:36 PM Alistair Francis wrote: > > On Sun, Jan 17, 2021 at 5:30 PM Olof Johansson wrote: > > > > Hi Alistair, > > > > On Sun, Jan 17, 2021 at 3:09 PM Alistair Francis wrote: > > > > > > This defconfig is based on the one released by reMarkable with their > > > 4.14 kernel. I have updated it to match the latest kernels. > > > > > > Signed-off-by: Alistair Francis > > > > It's awesome to see upstream support for contemporary consumer > > products being posted, thanks! > > No worries! > > > > > When it comes to a dedicated defconfig, is that necessary in this > > case? The needed drivers should be possible to enable either in > > imx_v6_v7_defconfig, or in multi_v7_defconfig (or, rather, both)? > > Most of the defconfi could be shared with a standard imx7 config, but > some of the extra components like the Wacom digitiser, > cyttsp5_i2c_adapter, max77818 and bd71815 might be better off in it's > own defconfig. > > If the maintainers are happy with enabling some of those in a imx7 > defconfig then I'm happy to do that. I have tried to split out the > config changes (I have two otehr series that build on this one) so it > should be easy to rebase it all on a standard one. Yeah, enabling those in imx_v6_v7_defconfig and multi_v7_defconfig is fine (or, really, desirable and preferred). Please enable as modules where possible (i.e anything that's fine to wait loading until after rootfs is mounted), to avoid kernel image growth on platforms that don't need those drivers. > > Adding new defconfigs is something we're avoiding as much as possible, > > since it adds CI overhead, and defconfigs easily get churny due to > > options moving around. > > > > In some cases we do it once per SoC family (i.e. the i.MX defconfigs), > > but we avoid it for products. > > Makes sense, I will update my patches not to use a custom defconfig. Awesome, thanks! -Olof