From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751487AbdK3UVu (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Nov 2017 15:21:50 -0500
Received: from mail-lf0-f68.google.com ([209.85.215.68]:43844 "EHLO
        mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750761AbdK3UVt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2017 15:21:49 -0500
X-Google-Smtp-Source: AGs4zMa/hKpBkJAjrXu4ZkwAYBxIktzk2xec1lDJQFrA1utYi+VMj+wukcbRAgZgPoituLYBpvAlQsOQTSPds3F2QTU=
MIME-Version: 1.0
X-Originating-IP: [209.133.79.7]
In-Reply-To: <mhng-81e38176-6ac2-4c03-8dbe-b3194494a5b8@palmer-si-x1c4>
References: <20171130183032.GA28365@infradead.org> <mhng-81e38176-6ac2-4c03-8dbe-b3194494a5b8@palmer-si-x1c4>
From: Olof Johansson <olof@lixom.net>
Date: Thu, 30 Nov 2017 12:21:46 -0800
Message-ID: <CAOesGMhtFNPEoYXu8zXM6rtwsSYFEyFeyVpW+s9PE2PNtk=-hQ@mail.gmail.com>
Subject: Re: [patches] Re: [PATCH 08/10] RISC-V: Set __ARCH_WANT_RENAMEAT to
 pick up generic version
To: Palmer Dabbelt <palmer@sifive.com>
Cc: Christoph Hellwig <hch@infradead.org>, Albert Ou <albert@sifive.com>,
        patches@groups.riscv.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vAUKLs9o017629

On Thu, Nov 30, 2017 at 10:38 AM, Palmer Dabbelt <palmer@sifive.com> wrote:
> On Thu, 30 Nov 2017 10:30:32 PST (-0800), Christoph Hellwig wrote:
>>
>> On Wed, Nov 29, 2017 at 05:55:19PM -0800, Olof Johansson wrote:
>>>
>>> In file included from ../lib/audit.c:8:0:
>>> ../include/asm-generic/audit_dir_write.h:30:1: error: '__NR_renameat'
>>> undeclared here (not in a function); did you mean '__NR_renameat2'?
>>
>>
>>
>> I think the audit code should be fixed instead to not expect
>> __NR_renameat, gіven that it's not in the asm-generic default set.

Fair enough.

> For some reason I thought we'd decided to keep renameat in our port despite
> it no longer being in the default list so we could maintain some backwards
> compatibility, but after looking through my email it looks like I was wrong
> about that.
>
> I'm just going to drop this patch for now.  I haven't tried it, but I think
> this might just do the trick?

Seems reasonable to me.


>
> diff --git a/include/asm-generic/audit_dir_write.h
> b/include/asm-generic/audit_dir_write.h
> index da09fb986459..dd5a9dd7a102 100644
> --- a/include/asm-generic/audit_dir_write.h
> +++ b/include/asm-generic/audit_dir_write.h
> @@ -27,7 +27,9 @@ __NR_mknod,
> __NR_mkdirat,
> __NR_mknodat,
> __NR_unlinkat,
> +#ifdef __NR_renameat
> __NR_renameat,
> +#endif
> __NR_linkat,
> __NR_symlinkat,
> #endif