From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C372ECAAD5 for ; Mon, 12 Sep 2022 07:05:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229688AbiILHF2 (ORCPT ); Mon, 12 Sep 2022 03:05:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbiILHFZ (ORCPT ); Mon, 12 Sep 2022 03:05:25 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 779211CFF4 for ; Mon, 12 Sep 2022 00:05:24 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id v16so17905306ejr.10 for ; Mon, 12 Sep 2022 00:05:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Kf+FkOZAH6AiTAa/Q5l98MlMhVQ6qbmRpLywVY10mCk=; b=PT7Vu5cz2P1peiG8JmLn2GwcbupWOSdW6QG2r2oxPQ66p/B3g9Xe5GZHDdeDDIKCC3 YUtV5XVdg/9N9GyN1gByyrJMERlxwo4VaUzUHAHbTvGYF1SANtCLm6FV9aemWBjHcr6U 4hfPm+2zW71DtHZ0i7l1Ip7jS8pLrLdia/E9I8QQCI5IC1Ww3HprBOt04cw5IGcXnH0F 3+nZ8CHDL1DWyvIPsap+GGjA9uCmcmoomUtQnnmhIJIPK74LBOYGUr3VSWMaLeKGdn8Y H0erMsBLzYk3vt4vbZMflE1rtGXWnvfvj6SYRQOidg60Sg1jwtv4bd46i7Nf42J4APau /JWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Kf+FkOZAH6AiTAa/Q5l98MlMhVQ6qbmRpLywVY10mCk=; b=XWEQM2cnsHcyA8nBzGjQJJsy1jo3bZSeTjAPXreykhFJk8yGaFt9NGVgXBj+Zq/Sme JtFVCntyuCu61L3xnHQoZbm4PZPl5ZfpfoLR/QuojYxomQHYI8XGHXihmhi6IPGBVwpa tQ8/2xwaDiFRmoUIVdRl6jw1Qvl+apl4UlbBTwweRz93GCkHAvZSmiqcgJIQX9P48tB8 EfZYAP3j/6vhAHvMx8Of4AiqGxfvdLpzSKxTr1XxUFeCX2hrPgK35Pg26l9VQNlQmOz1 AO4/CLg7tFW61jK763xNL71UMH6X8RtYqkblTfELrHV6QDMC/ELbmG03BSOsvl5NvO9k NMkA== X-Gm-Message-State: ACgBeo2gjHlX8MB45HRUduQ1sqD4fhN14JYvnlaA5+YvAQOI7d8rspMi +4b+qbNEV6upa3IZCpLbYCCjvx252enOnlJKEKjF3w== X-Google-Smtp-Source: AA6agR4juZkX/WWMyqANDFVwY1iR8lzXvuj5BbeRyk8aFY1KG7jPxHEziPtntEOXo4NBSAdqjxZweFWNo+JWMXWPtro= X-Received: by 2002:a17:907:1690:b0:77c:37be:2345 with SMTP id hc16-20020a170907169000b0077c37be2345mr4714757ejc.359.1662966322965; Mon, 12 Sep 2022 00:05:22 -0700 (PDT) MIME-Version: 1.0 References: <20220817202538.21493-1-leoyang.li@nxp.com> <20220817202538.21493-2-leoyang.li@nxp.com> In-Reply-To: <20220817202538.21493-2-leoyang.li@nxp.com> From: Olof Johansson Date: Mon, 12 Sep 2022 00:05:11 -0700 Message-ID: Subject: Re: [PATCH v4 1/2] arm64: dts: lx2160a: update PCIe nodes to match rev2 silicon To: Li Yang Cc: shawnguo@kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hou Zhiqiang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Aug 17, 2022 at 1:26 PM Li Yang wrote: > > The original dts was created based on the non-production rev1 silicon > which was only used for evaluation. Update the PCIe nodes to align with > the different controller used in production rev2 silicon. How can I confirm what version of silicon I have on a system? My non-evaluation commercially purchased system (HoneyComb LX2K) has: # cat /sys/bus/soc/devices/soc0/revision 1.0 And I will be really grumpy if this system stops working. It's what I use to do all my maintainer work, even if that's been fairly dormant this year. It's overall setting off red flags to update an in-place devicetree to a "new revision" of silicon instead of adding a new DT for said revision. 2160A has been on the market for several years, so it just seems odd to all of the sudden retroactively make things non-backwards-compatible. -Olof -Olof