From: Olof Johansson <olof@lixom.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Rob Herring <robherring2@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/2] drivers/core/of: Add symlink to device-tree from devices with an OF node
Date: Tue, 17 Feb 2015 14:22:17 -0800 [thread overview]
Message-ID: <CAOesGMi6METCJHwm3n=D0jdY7snhX=b2emw6UbSEHAj5WCxoZA@mail.gmail.com> (raw)
In-Reply-To: <1424059156.21410.38.camel@kernel.crashing.org>
On Sun, Feb 15, 2015 at 7:59 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> So I've been annoyed lately with having a bunch of devices such as i2c
> eeproms (for use by VPDs, server world !) and other bits and pieces that
> I want to be able to identify from userspace, and possibly provide
> additional data about from FW.
>
> Basically, it boils down to correlating the sysfs device with the OF
> tree device node, so that user space can use device-tree info such as
> additional "location" or "label" (or whatever else we can come up with)
> properties to identify a given device, or get some attributes of use
> about it, etc...
>
> Now, so far, we've done that in some subsystem in a fairly ad-hoc basis
> using "devspec" properties. For example, PCI creates them if it can
> correlate the probed device with a DT node. Some powerpc specific busses
> do that too.
>
> However, i2c doesn't and it would be nice to have something more generic
> since technically any device can have a corresponding device tree node
> these days.
>
> This patch achieves this by adding an "of_node" symlink to devices that
> have a non-NULL dev->of_node pointer.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Concept:
Acked-by: Olof Johansson <olof@lixom.net>
We've come across similar needs on product, and always had to do some
less-than-optimal alternate solution. This seems like a good idea to
me.
-Olof
prev parent reply other threads:[~2015-02-17 22:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 3:59 [PATCH 2/2] drivers/core/of: Add symlink to device-tree from devices with an OF node Benjamin Herrenschmidt
2015-02-16 9:56 ` Arnd Bergmann
2015-02-17 15:00 ` Rob Herring
2015-02-17 15:09 ` Greg Kroah-Hartman
2015-02-17 22:16 ` Benjamin Herrenschmidt
2015-02-17 22:22 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOesGMi6METCJHwm3n=D0jdY7snhX=b2emw6UbSEHAj5WCxoZA@mail.gmail.com' \
--to=olof@lixom.net \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).