linux-next: Fixes tag needs some work in the arm-soc tree

linux-next: Fixes tag needs some work in the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Hi all,

n commit

  0ff15a86d0c5 ("ARM: dts: stm32: Add power-supply for DSI panel on stm32f469-disco")

Fixes tag

  Fixes: 18c8866266 ("ARM: dts: stm32: Add display support on stm32f469-disco")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

Also, please keep the commit message tags together.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the arm-soc tree

[Olof Johansson]

Stephen,

On Sun, Jan 12, 2020 at 11:56 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> n commit
>
>   0ff15a86d0c5 ("ARM: dts: stm32: Add power-supply for DSI panel on stm32f469-disco")
>
> Fixes tag
>
>   Fixes: 18c8866266 ("ARM: dts: stm32: Add display support on stm32f469-disco")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
>
> Also, please keep the commit message tags together.

Thanks for the report, we'll keep an eye out for these formatting
tweaks in the future.

Alexandre; no respin needed to fix this IMHO, just something to keep in mind.

-Olof

Re: linux-next: Fixes tag needs some work in the arm-soc tree

[Arnd Bergmann]

On Mon, Feb 28, 2022 at 4:51 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   ed40a635b5ec ("soc: microchip: make mpfs_sys_controller_put static")
>
> Fixes tag
>
>   Fixes: dsafsdfd0054 ("soc: add microchip polarfire soc system controller")
>
> has these problem(s):
>
>   - No SHA1 recognised
>
> Maybe you meant
>
> Fixes: d0054a470c33 ("soc: add microchip polarfire soc system controller")

Fixed, thanks!

linux-next: Fixes tag needs some work in the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

Hi all,

In commit

  ed40a635b5ec ("soc: microchip: make mpfs_sys_controller_put static")

Fixes tag

  Fixes: dsafsdfd0054 ("soc: add microchip polarfire soc system controller")

has these problem(s):

  - No SHA1 recognised

Maybe you meant

Fixes: d0054a470c33 ("soc: add microchip polarfire soc system controller")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

Hi all,

In commit

  4bb1eb3cd4bd ("arm64: dts: actions: limit address range for pinctrl node")

Fixes tag

  Fixes: 7cdf8446ed1d ("arm64: dts: actions: Add pinctrl node for Actions

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line. Also keep all
the commit message tags together at the end fo te commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the arm-soc tree

[Sudeep Holla]

On Thu, Nov 14, 2019 at 08:21:22PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> n commit
>
>   9a6edfe32f37 ("firmware: arm_scmi: Fix doorbell ring logic for !CONFIG_64BIT")
>
> Fixes tag
>
>   Fixes: 823839571d76 ("firmware: arm_scmi: Make use SCMI v2.0 fastchannel
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.
>

My bad, and sorry for that, it was too long and hence I split it into 2 lines.

--
Regards,
Sudeep

linux-next: Fixes tag needs some work in the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi all,

n commit

  9a6edfe32f37 ("firmware: arm_scmi: Fix doorbell ring logic for !CONFIG_64BIT")

Fixes tag

  Fixes: 823839571d76 ("firmware: arm_scmi: Make use SCMI v2.0 fastchannel

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

Hi all,

In commit

  ca33f735b119 ("arm64: dts: bitmain: Modify pin controller memory map")

Fixes tag

  Fixes: af2ff87de413 ("arm64: dts: bitmain: Add pinctrl support for BM1880 SoC")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: c1294fb5cb78 ("arm64: dts: bitmain: Add pinctrl support for BM1880 SoC")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

Hi all,

In commit

  772775c1dfe0 ("net: lpc-enet: fix badzero.cocci warnings")

Fixes tag

  Fixes: e42016eb3844 ("net: lpc-enet: allow compile testing")

has these problem(s):

  - Target SHA1 does not exist

I can't quickly find which commit was meant :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

Hi all,

In commit

  dbc3c6295195 ("ARM: ux500: add missing of_node_put()")

Fixes tag

  Fixes: commit 18a992787896 ("ARM: ux500: move soc_id driver to drivers/soc")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]