From: Viresh Kumar <viresh.kumar@linaro.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Mike Turquette <mturquette@linaro.org>,
spear-devel <spear-devel@list.st.com>,
stable <stable@vger.kernel.org>
Subject: Re: [patch 1/2] clk: spear3xx: Use proper control register offset
Date: Fri, 20 Jun 2014 10:21:34 +0530 [thread overview]
Message-ID: <CAOh2x==Z3506u2DGZfRyTPs809npg0kZwMmNVV2C3X3dBKmDOw@mail.gmail.com> (raw)
In-Reply-To: <20140619215140.259138132@linutronix.de>
On Fri, Jun 20, 2014 at 3:22 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> The control register is at offset 0x10, not 0x0. This is wreckaged
> since commit 5df33a62c (SPEAr: Switch to common clock framework).
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: stable@vger.kernel.org
> ---
> drivers/clk/spear/spear3xx_clock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/drivers/clk/spear/spear3xx_clock.c
> ===================================================================
> --- linux.orig/drivers/clk/spear/spear3xx_clock.c
> +++ linux/drivers/clk/spear/spear3xx_clock.c
> @@ -211,7 +211,7 @@ static inline void spear310_clk_init(voi
> /* array of all spear 320 clock lookups */
> #ifdef CONFIG_MACH_SPEAR320
>
> -#define SPEAR320_CONTROL_REG (soc_config_base + 0x0000)
> +#define SPEAR320_CONTROL_REG (soc_config_base + 0x0010)
> #define SPEAR320_EXT_CTRL_REG (soc_config_base + 0x0018)
>
> #define SPEAR320_UARTX_PCLK_MASK 0x1
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
next prev parent reply other threads:[~2014-06-20 4:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 21:52 [patch 0/2] clk: spear3xx: Make it actually work Thomas Gleixner
2014-06-19 21:52 ` [patch 1/2] clk: spear3xx: Use proper control register offset Thomas Gleixner
2014-06-20 4:51 ` Viresh Kumar [this message]
2014-06-19 21:52 ` [patch 2/2] clk: spear3xx: Set proper clock parent of uart1/2 Thomas Gleixner
2014-06-20 5:41 ` Viresh Kumar
2014-06-20 7:53 ` Thomas Gleixner
2014-07-13 14:12 ` [patch 0/2] clk: spear3xx: Make it actually work Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOh2x==Z3506u2DGZfRyTPs809npg0kZwMmNVV2C3X3dBKmDOw@mail.gmail.com' \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=spear-devel@list.st.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).