From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755762AbcIMIHq (ORCPT ); Tue, 13 Sep 2016 04:07:46 -0400 Received: from mail-vk0-f67.google.com ([209.85.213.67]:35676 "EHLO mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbcIMIHo (ORCPT ); Tue, 13 Sep 2016 04:07:44 -0400 MIME-Version: 1.0 In-Reply-To: <475899b2-a0fc-7bd9-43fe-c83c390158ff@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <57806eb1-10ed-582e-72d0-2975e1ee967a@users.sourceforge.net> <475899b2-a0fc-7bd9-43fe-c83c390158ff@users.sourceforge.net> From: Ilya Dryomov Date: Tue, 13 Sep 2016 10:07:42 +0200 Message-ID: Subject: Re: [PATCH 15/47] block-rbd: Rename jump labels in rbd_dev_create() To: SF Markus Elfring Cc: Ceph Development , Alex Elder , Sage Weil , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 9:00 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 12 Sep 2016 18:12:39 +0200 > > Adjust jump labels according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > drivers/block/rbd.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > index 6acddc53..262805a 100644 > --- a/drivers/block/rbd.c > +++ b/drivers/block/rbd.c > @@ -4930,23 +4930,22 @@ static struct rbd_device *rbd_dev_create(struct rbd_client *rbdc, > minor_to_rbd_dev_id(1 << MINORBITS), > GFP_KERNEL); > if (rbd_dev->dev_id < 0) > - goto fail_rbd_dev; > + goto free_device; > > sprintf(rbd_dev->name, RBD_DRV_NAME "%d", rbd_dev->dev_id); > rbd_dev->task_wq = alloc_ordered_workqueue("%s-tasks", WQ_MEM_RECLAIM, > rbd_dev->name); > if (!rbd_dev->task_wq) > - goto fail_dev_id; > + goto remove_id; > > /* we have a ref from do_rbd_add() */ > __module_get(THIS_MODULE); > > dout("%s rbd_dev %p dev_id %d\n", __func__, rbd_dev, rbd_dev->dev_id); > return rbd_dev; > - > -fail_dev_id: > + remove_id: > ida_simple_remove(&rbd_dev_id_ida, rbd_dev->dev_id); > -fail_rbd_dev: > + free_device: > rbd_dev_free(rbd_dev); > return NULL; > } > -- > 2.10.0 > Really? I mean out_err -> free_device I can understand, but this? Thanks, Ilya