* 'current_state' is uninitialized in rbd_object_map_update_finish()
@ 2019-11-13 1:35 Tony Lu
2019-11-13 11:21 ` Ilya Dryomov
0 siblings, 1 reply; 2+ messages in thread
From: Tony Lu @ 2019-11-13 1:35 UTC (permalink / raw)
To: idryomov; +Cc: linux-block, linux-kernel
Hello,
There is a warning during compiling driver rbd for uninitialized
'current state' in rbd_object_map_update_finish():
drivers/block/rbd.c: In function 'rbd_object_map_callback':
drivers/block/rbd.c:2122:21: warning: ‘current_state’ may be used uninitialized in this function [-Wmaybe-uninitialized]
(current_state == OBJECT_EXISTS && state == OBJECT_EXISTS_CLEAN))
drivers/block/rbd.c:2090:23: note: ‘current_state’ was declared here
u8 state, new_state, current_state;
^~~~~~~~~~~~~
Cheers.
Tony Lu
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 'current_state' is uninitialized in rbd_object_map_update_finish()
2019-11-13 1:35 'current_state' is uninitialized in rbd_object_map_update_finish() Tony Lu
@ 2019-11-13 11:21 ` Ilya Dryomov
0 siblings, 0 replies; 2+ messages in thread
From: Ilya Dryomov @ 2019-11-13 11:21 UTC (permalink / raw)
To: Tony Lu; +Cc: linux-block, LKML
On Wed, Nov 13, 2019 at 2:35 AM Tony Lu <tonylu@linux.alibaba.com> wrote:
>
> Hello,
>
> There is a warning during compiling driver rbd for uninitialized
> 'current state' in rbd_object_map_update_finish():
>
> drivers/block/rbd.c: In function 'rbd_object_map_callback':
> drivers/block/rbd.c:2122:21: warning: ‘current_state’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> (current_state == OBJECT_EXISTS && state == OBJECT_EXISTS_CLEAN))
>
> drivers/block/rbd.c:2090:23: note: ‘current_state’ was declared here
> u8 state, new_state, current_state;
> ^~~~~~~~~~~~~
Hi Tony,
It looks like this warning was also reported by kbuild, on gcc 6.3 and
7.4. It's bogus, I'll send a patch to silence it.
Thanks,
Ilya
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-13 11:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 1:35 'current_state' is uninitialized in rbd_object_map_update_finish() Tony Lu
2019-11-13 11:21 ` Ilya Dryomov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).