From: Ilya Dryomov <idryomov@gmail.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>,
Jeremi Piotrowski <jeremi.piotrowski@gmail.com>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Phillip Lougher <phillip@squashfs.org.uk>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vfs: Don't reject unknown parameters
Date: Thu, 12 Dec 2019 18:13:55 +0100 [thread overview]
Message-ID: <CAOi1vP9E2yLeFptg7o99usEi=x3kf=NnHYdURXPhX4vTXKCTCQ@mail.gmail.com> (raw)
In-Reply-To: <20191212145042.12694-1-labbott@redhat.com>
On Thu, Dec 12, 2019 at 3:51 PM Laura Abbott <labbott@redhat.com> wrote:
>
> The new mount API currently rejects unknown parameters if the
> filesystem doesn't have doesn't take any arguments. This is
> unfortunately a regression from the old API which silently
> ignores extra arguments. This is easly seen with the squashfs
> conversion (5a2be1288b51 ("vfs: Convert squashfs to use the new
> mount API")) which now fails to mount with extra options. Just
> get rid of the error.
>
> Fixes: 3e1aeb00e6d1 ("vfs: Implement a filesystem superblock
> creation/configuration context")
> Link: https://lore.kernel.org/lkml/20191130181548.GA28459@gentoo-tp.home/
> Reported-by: Jeremi Piotrowski <jeremi.piotrowski@gmail.com>
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1781863
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> fs/fs_context.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/fs_context.c b/fs/fs_context.c
> index 138b5b4d621d..7ec20b1f8a53 100644
> --- a/fs/fs_context.c
> +++ b/fs/fs_context.c
> @@ -160,8 +160,7 @@ int vfs_parse_fs_param(struct fs_context *fc, struct fs_parameter *param)
> return 0;
> }
>
> - return invalf(fc, "%s: Unknown parameter '%s'",
> - fc->fs_type->name, param->key);
> + return 0;
> }
> EXPORT_SYMBOL(vfs_parse_fs_param);
Hi Laura,
I'm pretty sure this is a regression for all other filesystems
that used to check for unknown tokens and return an error from their
->mount/fill_super/etc methods before the conversion.
All filesystems that provide ->parse_param expect that ENOPARAM is
turned into an error with an error message. I think we are going to
need something a bit more involved in vfs_parse_fs_param(), or just
a dummy ->parse_param for squashfs that would always return 0.
Thanks,
Ilya
next prev parent reply other threads:[~2019-12-12 17:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 14:50 [PATCH] vfs: Don't reject unknown parameters Laura Abbott
2019-12-12 17:13 ` Ilya Dryomov [this message]
2019-12-12 17:47 ` Laura Abbott
2019-12-12 17:56 ` Linus Torvalds
2019-12-12 20:01 ` Laura Abbott
2019-12-12 21:36 ` Al Viro
2019-12-13 9:15 ` Miklos Szeredi
2019-12-13 9:30 ` Miklos Szeredi
2019-12-17 17:46 ` Al Viro
2019-12-17 17:49 ` David Howells
2019-12-17 18:08 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOi1vP9E2yLeFptg7o99usEi=x3kf=NnHYdURXPhX4vTXKCTCQ@mail.gmail.com' \
--to=idryomov@gmail.com \
--cc=dhowells@redhat.com \
--cc=jeremi.piotrowski@gmail.com \
--cc=labbott@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@squashfs.org.uk \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).