From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755565AbcIMIBW (ORCPT ); Tue, 13 Sep 2016 04:01:22 -0400 Received: from mail-ua0-f193.google.com ([209.85.217.193]:36750 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbcIMIBT (ORCPT ); Tue, 13 Sep 2016 04:01:19 -0400 MIME-Version: 1.0 In-Reply-To: <71b06567-1ea9-204d-d61b-2af4426d9cd1@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <57806eb1-10ed-582e-72d0-2975e1ee967a@users.sourceforge.net> <71b06567-1ea9-204d-d61b-2af4426d9cd1@users.sourceforge.net> From: Ilya Dryomov Date: Tue, 13 Sep 2016 10:01:17 +0200 Message-ID: Subject: Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk() To: SF Markus Elfring Cc: Ceph Development , Alex Elder , Sage Weil , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 8:44 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 11 Sep 2016 13:37:34 +0200 > > Add a space character before a single jump label in this function > according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > drivers/block/rbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > index f4212e1..d61a066 100644 > --- a/drivers/block/rbd.c > +++ b/drivers/block/rbd.c > @@ -1064,7 +1064,7 @@ static int rbd_header_from_disk(struct rbd_device *rbd_dev, > header->snap_sizes = snap_sizes; > > return 0; > -out_2big: > + out_2big: > ret = -EIO; > kfree(snap_sizes); > free_names: > -- > 2.10.0 > Can you point where this current convention is documented? Certainly not in CodingStyle, AFAICT... I know some people prefer a single space in there because it makes "diff -p" work better, but nowadays with "git diff" this argument is pretty moot. Thanks, Ilya