From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757371AbcIMJQR (ORCPT ); Tue, 13 Sep 2016 05:16:17 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:35416 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755963AbcIMJQP (ORCPT ); Tue, 13 Sep 2016 05:16:15 -0400 MIME-Version: 1.0 In-Reply-To: <121f05b0-ac94-4d81-289e-9dc3668eab95@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <57806eb1-10ed-582e-72d0-2975e1ee967a@users.sourceforge.net> <71b06567-1ea9-204d-d61b-2af4426d9cd1@users.sourceforge.net> <121f05b0-ac94-4d81-289e-9dc3668eab95@users.sourceforge.net> From: Ilya Dryomov Date: Tue, 13 Sep 2016 11:16:13 +0200 Message-ID: Subject: Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk() To: SF Markus Elfring , Jonathan Corbet Cc: Ceph Development , Alex Elder , Sage Weil , LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Jean Delvare Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8D9GLEG021602 On Tue, Sep 13, 2016 at 10:12 AM, SF Markus Elfring wrote: >>> @@ -1064,7 +1064,7 @@ static int rbd_header_from_disk(struct rbd_device *rbd_dev, >>> header->snap_sizes = snap_sizes; >>> >>> return 0; >>> -out_2big: >>> + out_2big: >>> ret = -EIO; >>> kfree(snap_sizes); >>> free_names: > … >> Can you point where this current convention is documented? > > Yes. > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51 Huh. That patch is not in Linus' tree. > > Do you find the software update "CodingStyle: Clarify and complete chapter 7" interesting? > > >> Certainly not in CodingStyle, AFAICT... > > I suggest to look at the current version once more. > > >> I know some people prefer a single space in there because it makes >> "diff -p" work better, but nowadays with "git diff" this argument is >> pretty moot. > > Would you like to discuss the corresponding software evolution a bit more? Jon, could you please yank 865a1caa4b6b ("CodingStyle: Clarify and complete chapter 7") from your linux-next branch or at least change "It is advised to indent labels" to something less stronger? It hasn't even hit mainline yet and we are already getting spammed. Looks like 9 out of 10 labels are not indented $ git grep '^[a-z0-9]\+:' -- *.c | wc -l 27945 $ git grep '^ [a-z0-9]\+:' -- *.c | wc -l 2925 so I'd say that's a bad advise as far as consistency goes, and the "diff -p" argument is pretty moot nowadays. Thanks, Ilya