From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751299AbcFNOjX (ORCPT ); Tue, 14 Jun 2016 10:39:23 -0400 Received: from caladan.dune.hu ([78.24.191.180]:57114 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750818AbcFNOjW convert rfc822-to-8bit (ORCPT ); Tue, 14 Jun 2016 10:39:22 -0400 MIME-Version: 1.0 In-Reply-To: <1465803534-25840-1-git-send-email-noltari@gmail.com> References: <1465803534-25840-1-git-send-email-noltari@gmail.com> From: Jonas Gorski Date: Tue, 14 Jun 2016 16:38:47 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/6] MIPS: BMIPS: add missing console to bcm96358nb4ser To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= Cc: MIPS Mailing List , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Ralf Baechle , Florian Fainelli , Kevin Cernekee , Rob Herring , Simon Arlott Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Álvaro, On 13 June 2016 at 09:38, Álvaro Fernández Rojas wrote: > Console definition is needed in order to avoid a warning in earlycon to > console transition. > > Signed-off-by: Álvaro Fernández Rojas > --- > arch/mips/boot/dts/brcm/bcm96358nb4ser.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts b/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts > index f412117..702eae2 100644 > --- a/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts > +++ b/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts Unfortunately I haven't seen this earlier, but please don't name the dts file bcm9* unless it's an actual reference/eval board from Broadcom. A more sensible name would be neufbox4-sercom.dts or bcm6358-neufbox4-sercom.dts. Regards Jonas