From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C25EEC54EED for ; Tue, 24 Jan 2023 20:41:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233453AbjAXUlr (ORCPT ); Tue, 24 Jan 2023 15:41:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229584AbjAXUlq (ORCPT ); Tue, 24 Jan 2023 15:41:46 -0500 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 541B44C0F6 for ; Tue, 24 Jan 2023 12:41:45 -0800 (PST) Received: by mail-pf1-x42b.google.com with SMTP id 20so12041358pfu.13 for ; Tue, 24 Jan 2023 12:41:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atishpatra.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kArh2JTETPG4MZN8AtzWKM/hnB740sJiaw+6d2XmltY=; b=oyLp/nUpTQCOQMyT5yEtRG7o0JQPEbxztyhTTwBBWfbRApCOOFV/WkDLdIbvbSvWLz b1hrf5/g8Fdn++whjE9zqRHbe7cRC42175lcv4Eyj7FJEwCFaWE1ruLkzMZpzPw3MEn6 dm8HGLCYb86tX0qQL+B4f0kcnhqKsu6O9j+KA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kArh2JTETPG4MZN8AtzWKM/hnB740sJiaw+6d2XmltY=; b=27R/eRr1Lh+vRSiitcMUUy/+hbQtNK3AFcmFd8p9CWkme3QxLpTYzrQRj3dpcQKjNI /0JH+s0Hg1DYu0Pe34//q33CMOQVh4Eivjhs2V/PRNfIO08umVcB/j7xtXojw24mSyXS VAOIl4oplxkQ2lS0/RK4SYWiWc/AnrUc0R6ykhDKIbJoV3Fmm814fHckEcP59Nt8693f L5TkqDIswekYmzPyhJTGbVhpcBvFVn65r93xkmhvqrZekN+CnXYdKmB3QMxg4XmH6oe2 VSFpi6EowzM3xyVvJ+ZD4GKrEPK+Qbz33LrUZKN+d/6T2y3uxo55G51X7z6Dj4KYNld7 YnIA== X-Gm-Message-State: AFqh2kpMAenhSKaGXyYS2NQRJ91IHOVi/CSCkMebqFoauuWDOlIlBky6 yXu0EgVv5oBgZhFhe9+tQWOvpQzahisVHztiChGg X-Google-Smtp-Source: AMrXdXv//TSHap1rIs4T8t6FimYpSoWP8wIEH1RnksqTCs7706WWqSUBG8nxukPl0ALp6mPXwdjofzthPg+fGXMiqgg= X-Received: by 2002:a05:6a00:1d23:b0:58d:b662:af11 with SMTP id a35-20020a056a001d2300b0058db662af11mr2817916pfx.37.1674592904836; Tue, 24 Jan 2023 12:41:44 -0800 (PST) MIME-Version: 1.0 References: <20221215170046.2010255-1-atishp@rivosinc.com> <20221215170046.2010255-2-atishp@rivosinc.com> <20230112100608.d7tnvhbotjfctlgk@orel> <20230113072255.34cnyautbwiy25p5@orel> In-Reply-To: <20230113072255.34cnyautbwiy25p5@orel> From: Atish Patra Date: Tue, 24 Jan 2023 12:41:33 -0800 Message-ID: Subject: Re: [PATCH v2 01/11] RISC-V: Define helper functions expose hpm counter width and count To: Andrew Jones Cc: Atish Kumar Patra , linux-kernel@vger.kernel.org, Anup Patel , Guo Ren , kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-riscv@lists.infradead.org, Mark Rutland , Palmer Dabbelt , Paul Walmsley , Sergey Matyukevich , Eric Lin , Will Deacon Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2023 at 11:22 PM Andrew Jones wrote: > > On Thu, Jan 12, 2023 at 10:18:05AM -0800, Atish Kumar Patra wrote: > > On Thu, Jan 12, 2023 at 2:06 AM Andrew Jones wrote: > > > > > > On Thu, Dec 15, 2022 at 09:00:36AM -0800, Atish Patra wrote: > ... > > > > +EXPORT_SYMBOL(riscv_pmu_get_hpm_info); > > > > > > EXPORT_SYMBOL_GPL ? > > > > > > > Is that mandatory ? I have seen usage of both in arch/riscv and other > > places though. > > I am also not sure if any other non-GPL module should/need access to this. > > TBH, I'm not sure what the best policy is, but I presumed we should use > _GPL when we aren't aware of anything non-GPL and then when a day comes > that something non-GPL would like this to be exported, the patch that > flips it will provide the justification in its commit message. > Sgtm. Changed it to EXPORT_SYMBOL_GPL for now. > Thanks, > drew -- Regards, Atish