From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D197C2D0A3 for ; Sat, 7 Nov 2020 00:53:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CED09206E3 for ; Sat, 7 Nov 2020 00:53:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=atishpatra.org header.i=@atishpatra.org header.b="Gm+gGA0z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728153AbgKGAxv (ORCPT ); Fri, 6 Nov 2020 19:53:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727129AbgKGAxq (ORCPT ); Fri, 6 Nov 2020 19:53:46 -0500 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B66DC0613D2 for ; Fri, 6 Nov 2020 16:53:46 -0800 (PST) Received: by mail-io1-xd42.google.com with SMTP id k21so3325295ioa.9 for ; Fri, 06 Nov 2020 16:53:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atishpatra.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=htvs7lR/1BI8D0Mzc+TXEsKixscjGZpRTsGr1YNtxI4=; b=Gm+gGA0zABCYmnzgAZbqB8LmrvQ24MZCZCeuofocA24Z9DinusB4T1r6s3QuIsHnq/ BDgTerVHPvQuevB4yFhOhYW29XoCPLIvMjMF66TkV6n1x1WAtyJgsMXb/N5zpnI9faJa FIOqUay2ys7nfNVAmyM7TMxQWX7Rcmmu7ZLY4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=htvs7lR/1BI8D0Mzc+TXEsKixscjGZpRTsGr1YNtxI4=; b=RxuSZJD3UFLwa1KvesHyz3EbWezHxMXVc/u6PdtkOJZTIw+3pnN9vj119DYrEakRkK rx/F9UDLTutppScm6KjINEmLfwtiW9ra5EUUJ+Pmy7BSz5cXwGc1GBp8eIqpZKGvb8m6 fm91u6uW1VSAhOy+NvmnBM+GjGzqe3kU96f1uQnO0nto4nyauP9iikLSec3fG2xO4mRy afA5+QxZaBPrlIYFEsvRecz6rCbafwO9+G07PxCryqBsfLOSJfL8CXjsvxHzn4wW50Ch AjGM4U/q4rWMHTCe4Ac5lig0rNMOwqbKy/1gFdPiXePFqLO5e5/Q1z11Ko5YyXXp32+P zNoA== X-Gm-Message-State: AOAM531dZ83F/VLNWXNI+4p1aVkjxRzBh3iXEK3MGQTr5cLE9DwZT1a8 5+qyOpSHDHFMkXMjKnaGMDPBm1Scgou4J6JES2zj X-Google-Smtp-Source: ABdhPJyTo+S+mQWAmRQ8EDSKdeh04ebDM4c/nGCflyQ+HMbV7hMgiFw6U1U5Deqk5cCMRheBFpX7520CFYInwaVMtLw= X-Received: by 2002:a5d:9842:: with SMTP id p2mr3570190ios.113.1604710425638; Fri, 06 Nov 2020 16:53:45 -0800 (PST) MIME-Version: 1.0 References: <20201006001752.248564-1-atish.patra@wdc.com> <20201006001752.248564-3-atish.patra@wdc.com> <20201106171403.GK29329@gaia> <20201106190847.GA23792@gaia> In-Reply-To: <20201106190847.GA23792@gaia> From: Atish Patra Date: Fri, 6 Nov 2020 16:53:33 -0800 Message-ID: Subject: Re: [PATCH v4 2/5] arm64, numa: Change the numa init functions name to be generic To: Catalin Marinas Cc: Atish Patra , Kefeng Wang , David Hildenbrand , Jonathan Cameron , Zong Li , linux-riscv , Will Deacon , linux-arch@vger.kernel.org, Lorenzo Pieralisi , Jia He , Anup Patel , "Rafael J. Wysocki" , Steven Price , Greentime Hu , Albert Ou , Arnd Bergmann , Anshuman Khandual , Paul Walmsley , "linux-arm-kernel@lists.infradead.org" , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org List" , Palmer Dabbelt , Mike Rapoport , Andrew Morton , Nicolas Saenz Julienne Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 6, 2020 at 11:08 AM Catalin Marinas wrote: > > On Fri, Nov 06, 2020 at 09:33:14AM -0800, Atish Patra wrote: > > On Fri, Nov 6, 2020 at 9:14 AM Catalin Marinas wrote: > > > On Mon, Oct 05, 2020 at 05:17:49PM -0700, Atish Patra wrote: > > > > diff --git a/arch/arm64/kernel/acpi_numa.c b/arch/arm64/kernel/acpi_numa.c > > > > index 7ff800045434..96502ff92af5 100644 > > > > --- a/arch/arm64/kernel/acpi_numa.c > > > > +++ b/arch/arm64/kernel/acpi_numa.c > > > > @@ -117,16 +117,3 @@ void __init acpi_numa_gicc_affinity_init(struct acpi_srat_gicc_affinity *pa) > > > > > > > > node_set(node, numa_nodes_parsed); > > > > } > > > > - > > > > -int __init arm64_acpi_numa_init(void) > > > > -{ > > > > - int ret; > > > > - > > > > - ret = acpi_numa_init(); > > > > - if (ret) { > > > > - pr_info("Failed to initialise from firmware\n"); > > > > - return ret; > > > > - } > > > > - > > > > - return srat_disabled() ? -EINVAL : 0; > > > > -} > > > > > > I think it's better if arm64_acpi_numa_init() and arm64_numa_init() > > > remained in the arm64 code. It's not really much code to be shared. > > > > RISC-V will probably support ACPI one day. The idea is to not to do > > exercise again in future. > > Moreover, there will be arch_numa_init which will be used by RISC-V > > and there will be arm64_numa_init > > used by arm64. However, if you feel strongly about it, I am happy to > > move back those two functions to arm64. > > I don't have a strong view on this, only if there's a risk at some point > of the implementations diverging (e.g. quirks). We can revisit it if > that happens. > Sure. I seriously hope we don't have to deal with arch specific quirks in future. > It may be worth swapping patches 1 and 2 so that you don't have an > arm64_* function in the core code after the first patch (more of a > nitpick). Either way, feel free to add my ack on both patches: > Sure. I will swap 1 & 2 and resend the series. > Acked-by: Catalin Marinas Thanks. -- Regards, Atish