From: "Robert O'Callahan" <rocallahan@gmail.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: Kyle Huey <me@kylehuey.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Gabriel Krisman Bertazi <krisman@collabora.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken
Date: Mon, 1 Feb 2021 15:25:44 +1300 [thread overview]
Message-ID: <CAOp6jLaKR3zJDg9bNFkTcj78kKDtrdnMF4U-mxzkXDRgHu94GA@mail.gmail.com> (raw)
In-Reply-To: <CALCETrVZp6-1Rg_DEKggUqZAzQ_iXXMd4d690ByPGb8B9F6dzQ@mail.gmail.com>
On Mon, Feb 1, 2021 at 12:40 PM Andy Lutomirski <luto@kernel.org> wrote:
> I admit that PTRACE_SINGLESTEP seems like an odd way to spell "advance
> to the end of the syscall", but you're right, it should work.
We don't know of any better way to advance to the end of the syscall
without executing any userspace instructions. We could set a
breakpoint at the syscall return address but weird edge cases
complicate that.
Rob
--
"He was pierced for our transgressions, he was crushed for our
iniquities; the punishment that brought us peace was upon him, and by
his wounds we are healed. We all, like sheep, have gone astray, each
of us has turned to his own way; and the LORD has laid on him the
iniquity of us all." [Isaiah 53:5-6]
prev parent reply other threads:[~2021-02-01 2:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 1:32 [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken Kyle Huey
2021-01-31 1:55 ` Linus Torvalds
2021-01-31 2:50 ` Kyle Huey
2021-01-31 18:54 ` Yuxuan Shui
2021-01-31 20:10 ` Linus Torvalds
2021-01-31 20:20 ` Gabriel Krisman Bertazi
2021-01-31 21:21 ` Linus Torvalds
2021-01-31 21:30 ` Linus Torvalds
2021-01-31 22:04 ` Andy Lutomirski
2021-01-31 22:08 ` Kyle Huey
2021-01-31 22:20 ` Andy Lutomirski
2021-01-31 22:27 ` Kyle Huey
2021-01-31 23:17 ` Kyle Huey
2021-01-31 23:35 ` Linus Torvalds
2021-01-31 23:55 ` Linus Torvalds
2021-02-03 18:00 ` [PATCH] entry: Fix missed trap after single-step on system call return Gabriel Krisman Bertazi
2021-02-03 18:10 ` Linus Torvalds
2021-02-03 18:18 ` Andy Lutomirski
2021-02-03 18:22 ` Linus Torvalds
2021-02-03 18:11 ` Kyle Huey
2021-02-03 23:55 ` Kyle Huey
2021-02-04 17:46 ` Linus Torvalds
2021-02-05 23:24 ` [tip: core/urgent] entry: Ensure " tip-bot2 for Gabriel Krisman Bertazi
2021-01-31 22:57 ` [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken Linus Torvalds
2021-01-31 23:36 ` Andy Lutomirski
2021-01-31 23:39 ` Kyle Huey
2021-01-31 23:40 ` Andy Lutomirski
2021-02-01 2:25 ` Robert O'Callahan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOp6jLaKR3zJDg9bNFkTcj78kKDtrdnMF4U-mxzkXDRgHu94GA@mail.gmail.com \
--to=rocallahan@gmail.com \
--cc=krisman@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=me@kylehuey.com \
--cc=robert@ocallahan.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).