From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FA64C433EF for ; Mon, 13 Sep 2021 16:57:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BD3E61029 for ; Mon, 13 Sep 2021 16:57:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241170AbhIMQ6S (ORCPT ); Mon, 13 Sep 2021 12:58:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45618 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238966AbhIMQ6Q (ORCPT ); Mon, 13 Sep 2021 12:58:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631552219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g+3cqH6ifdVqKTPD8DSIcY8WRiPrRg0IjI4GufOGc8I=; b=Msp7aB1MnnFIoQcVFpmEF8x6z7ic0wfUmr4qs4z0RFBIj4yhykhXu/RdwJr08dsBy0TpQX 2DykgNtMzUX6tJGZ2HXMiQKF4DuhWKmkS04urQ0Bye4G+/v3cyjdXMjfHHtzvtP0nM/xQA wXwok8/1aYJ17rjf2Brg7ktQZGMwWDE= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-95-QJKlBiQQPAqQ1gzSO2VJqA-1; Mon, 13 Sep 2021 12:56:58 -0400 X-MC-Unique: QJKlBiQQPAqQ1gzSO2VJqA-1 Received: by mail-lj1-f199.google.com with SMTP id w28-20020a2e161c000000b001ba14fc0cd4so4486544ljd.10 for ; Mon, 13 Sep 2021 09:56:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g+3cqH6ifdVqKTPD8DSIcY8WRiPrRg0IjI4GufOGc8I=; b=EqIIvGzwWO/v4wjxAvb4Slyj7jDXH5IqFYffJX4maHmtgzTt3+BTOm5w6zepEZtggT iowc/ZPurNU53tryfEHkvDRosqQBvj8pFg7cLB+QIOt7qHB3tWPr5lnOXzBxHFYyCc2c QugD/SpDgJmKkxfn/gE+x4SKzcfM5A1KD5pl2lO+6bO3WOZirGdqn8oCXDUAo4TsyA5t nmLLMlEraqlWZajg6W12Nhqj9ZNemDaghF7qX8oOcE0wacoJHtClcr1DITlRaq+AFswc mEWTI0uC4S/ITrA9tC9BvkLy3Cq/hEqTUxOjt5ecKDJlFaVJO/re0ZfKQ1ddLPWx5yBT t1Cw== X-Gm-Message-State: AOAM530mVTPEMk6sg71m1HG9/WIlpF3Afd6xG0mOXDyzk6NNWsommS5w Ug2dwMzf4yXsRhqBfOHyZC+GivEyIlCewofODHAhVg5hK4nSwrqGKNBHOGAoopQ6GZdqI/8c1E/ IylepebY4dMCxeczB2v36w7zTurYaW8w7teNG4+w8 X-Received: by 2002:a2e:7304:: with SMTP id o4mr11659529ljc.51.1631552216993; Mon, 13 Sep 2021 09:56:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEsueuL9hseX4+IMXePvu65lhG7CpxBDTW6sDERh7JVYGERNaG5Xeiw6ppL+jq20MLxOXsjghqm8q8r+/BSJY= X-Received: by 2002:a2e:7304:: with SMTP id o4mr11659504ljc.51.1631552216735; Mon, 13 Sep 2021 09:56:56 -0700 (PDT) MIME-Version: 1.0 References: <20210913135745.13944-1-jgross@suse.com> <20210913135745.13944-3-jgross@suse.com> In-Reply-To: From: Eduardo Habkost Date: Mon, 13 Sep 2021 12:56:41 -0400 Message-ID: Subject: Re: [PATCH 2/2] kvm: rename KVM_MAX_VCPU_ID to KVM_MAX_VCPU_IDS To: Sean Christopherson Cc: Juergen Gross , kvm@vger.kernel.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Shuah Khan , Shuah Khan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 13, 2021 at 12:24 PM Sean Christopherson wrote: > > On Mon, Sep 13, 2021, Juergen Gross wrote: > > KVM_MAX_VCPU_ID is not specifying the highest allowed vcpu-id, but the > > number of allowed vcpu-ids. This has already led to confusion, so > > rename KVM_MAX_VCPU_ID to KVM_MAX_VCPU_IDS to make its semantics more > > clear > > My hesitation with this rename is that the max _number_ of IDs is not the same > thing as the max allowed ID. E.g. on x86, given a capability that enumerates the > max number of IDs, I would expect to be able to create vCPUs with arbitrary 32-bit > x2APIC IDs so long as the total number of IDs is below the max. > What name would you suggest instead? KVM_VCPU_ID_LIMIT, maybe? I'm assuming we are not going to redefine KVM_MAX_VCPU_ID to be an inclusive limit. -- Eduardo