From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60678C43466 for ; Mon, 21 Sep 2020 07:46:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10B802151B for ; Mon, 21 Sep 2020 07:46:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=benyossef-com.20150623.gappssmtp.com header.i=@benyossef-com.20150623.gappssmtp.com header.b="uQbRytZo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726420AbgIUHqo (ORCPT ); Mon, 21 Sep 2020 03:46:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726343AbgIUHqn (ORCPT ); Mon, 21 Sep 2020 03:46:43 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA69FC0613CF for ; Mon, 21 Sep 2020 00:46:43 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id k14so8294322pgi.9 for ; Mon, 21 Sep 2020 00:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=benyossef-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=KEQZ+0+MjbwK1ElZms1Qgb4W3im9WPY9mb97cPZoGK0=; b=uQbRytZokTI9uAROSbK3E3kPhHy0k8+bTpZNDdwFsDvSZV9ClRnTaGzPeJl+3iL46B B/W1PYvR4awrXTO9WDeUI88a4/UFNeFxMrmqMDYXOB+ZSF/dCv2jPWqMZnfgtYmwsgVA tiYAfKvnau0HbFLtG4zTFIPFGIDhMDYYxIVkDn9TFoYUJAlUrA+ThMqO47z/LPDN8XwY l/iueAjhsKKKTrKAnXkxA1Yd+11IsSnnNywcrSMMUQzhvsXpBteBJVvuSax7CrXyep0j enckp5UJM3mwjWfsZyMJo1NBUXfDvdBDoGt4/OwUT0OGM6UtAQcnMTDN5habb2LtNXdZ LbgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=KEQZ+0+MjbwK1ElZms1Qgb4W3im9WPY9mb97cPZoGK0=; b=cWz/RJVxJ/TUHyCO5slhkNPIUSEdvbAnV8a9sLJ8eXg02/Z8H2m67vSMZXDsbX9EwO bPKTGvAf2eocxRJCDQEbSKch3OweJodiEv3lE92pnI7XEkqPcQ+RCyjg7XTPonf57c8C o27ni7YLzOG7t1FX/Zz4NHcntwDzBTR38arxR0IcTUzxNh9sUGjnTcLlJgmE57+TdLDl 3n5F8aknEVeVfdVss1JZnHqonSGDWb18E6/EiZW0M/Uz7EkF3h3aulZ9z++DHbqIpk6Y wSGnv4AigW0DYphTpcC+KVTpOmfQ7KBNwxidOZ0gVuAM8MNTzbXiqlzPt+bAXK2vz32f xPvA== X-Gm-Message-State: AOAM533hcipfdT5Xr6CYlOSTsTxBWS2VQ++A+NChXejevsRZ4+p4PmwQ F68rjgI4QIb4aAR/FmTOu+t7PT7SPqK1RIQHqk8W3g== X-Google-Smtp-Source: ABdhPJyQpA8ZjwSRlnLg26q0TprnPeXcNQVwncIaeBqK+eZsI4FvBtCOdSwD5EFWTY+UqkN7XkuLHtDjs+xndIYZS4M= X-Received: by 2002:a17:902:758b:b029:d2:29fc:c841 with SMTP id j11-20020a170902758bb02900d229fcc841mr2054484pll.39.1600674403207; Mon, 21 Sep 2020 00:46:43 -0700 (PDT) MIME-Version: 1.0 References: <20200916071950.1493-3-gilad@benyossef.com> <202009162154.fxQ0Z6wT%lkp@intel.com> In-Reply-To: From: Gilad Ben-Yossef Date: Mon, 21 Sep 2020 10:46:32 +0300 Message-ID: Subject: Re: [PATCH 2/2] crypto: ccree - add custom cache params from DT file To: Nick Desaulniers Cc: kernel test robot , Herbert Xu , "David S. Miller" , Rob Herring , kbuild-all@lists.01.org, clang-built-linux , Network Development , Ofir Drang , Linux Crypto Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux kernel mailing list , Sami Tolvanen , Alex Elder , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Sep 18, 2020 at 10:39 PM Nick Desaulniers wrote: > > On Thu, Sep 17, 2020 at 12:20 AM Gilad Ben-Yossef w= rote: > > ... > > > > I am unable to understand this warning. It looks like it is > > complaining about a FIELD_GET sanity check that is always false, which > > makes sense since we're using a constant. > > > > Anyone can enlighten me if I've missed something? > > Looked at some of this code recently. I think it may have an issue > for masks where sizeof(mask) < sizeof(unsigned long long). > > In your code, via 0day bot: > > 107 u32 cache_params, ace_const, val, mask; > ... > > 120 cache_params |=3D FIELD_PREP(mask, val); > > then in include/linux/bitfield.h, we have: > > 92 #define FIELD_PREP(_mask, _val) \ > 93 ({ \ > 94 __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \ > > 44 #define __BF_FIELD_CHECK(_mask, _reg, _val, _pfx) \ > ... > 52 BUILD_BUG_ON_MSG((_mask) > (typeof(_reg))~0ull, \ > 53 _pfx "type of reg too small for mask"); \ > > so the 0ULL in FIELD_PREP is important. In __BF_FIELD_CHECK, the > typeof(_reg) is unsigned long long (because 0ULL was passed). So we > have a comparison between a u32 and a u64; indeed any u32 can never be > greater than a u64 that we know has the value of ULLONG_MAX. > > I did send a series splitting these up, I wonder if they'd help here: > https://lore.kernel.org/lkml/20200708230402.1644819-3-ndesaulniers@google= .com/ > -- Thanks! This indeed explains this. It seems there is nothing for me to do about it in the driver code though, as it seems the issue is in the macro and you have already posted a fix for it. Thanks again, Gilad --=20 Gilad Ben-Yossef Chief Coffee Drinker values of =CE=B2 will give rise to dom!