From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753992AbdKIJVy (ORCPT ); Thu, 9 Nov 2017 04:21:54 -0500 Received: from mail-ot0-f193.google.com ([74.125.82.193]:54953 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753957AbdKIJVv (ORCPT ); Thu, 9 Nov 2017 04:21:51 -0500 X-Google-Smtp-Source: AGs4zMa1Mr0zRNS1P/vVm2/LxxuAOqcBzjioBhPg1URMXxK26coWhgZVQWDYxEiJOfqxNpbtNk9GcXBKQ0H1FXBHGRs= MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] In-Reply-To: <20171109081305.3659-1-colin.king@canonical.com> References: <20171109081305.3659-1-colin.king@canonical.com> From: Gilad Ben-Yossef Date: Thu, 9 Nov 2017 11:21:50 +0200 Message-ID: Subject: Re: [PATCH] staging: ccree: remove unused pointer cc_base To: Colin King Cc: Greg Kroah-Hartman , Linux Crypto Mailing List , driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, Linux kernel mailing list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Colin, Thank you very much for your patch. On Thu, Nov 9, 2017 at 10:13 AM, Colin King wrote: > From: Colin Ian King > > Pointer cc_base is being assigned but is never read, hence it is > redundant and can be removed. Cleans up clang warning: > > drivers/staging/ccree/ssi_driver.c:235:2: warning: Value stored to > 'cc_base' is never read > > Signed-off-by: Colin Ian King > --- > drivers/staging/ccree/ssi_driver.c | 3 --- > 1 file changed, 3 deletions(-) Your patch is perfectly fine but I just happened to send a patch series that includes this fix but also deals with other occurrences of the same now no-longer needed cc_base variable just a second ago before checking my email... Sorry about that and thanks again. Gilad -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru