From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751208AbeCZGbZ (ORCPT ); Mon, 26 Mar 2018 02:31:25 -0400 Received: from mail-ua0-f196.google.com ([209.85.217.196]:45775 "EHLO mail-ua0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbeCZGbY (ORCPT ); Mon, 26 Mar 2018 02:31:24 -0400 X-Google-Smtp-Source: AG47ELsePOC/KqiLEJbdRZdSrSclVUDEa4DR2g8eEiPfyFxy7h7KCV4DByBbTTDrm/SgaWDaaDi+41Q9r0Yml1j65yk= MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] In-Reply-To: <1522003290-27243-1-git-send-email-yael.chemla@foss.arm.com> References: <1522003290-27243-1-git-send-email-yael.chemla@foss.arm.com> From: Gilad Ben-Yossef Date: Mon, 26 Mar 2018 09:31:23 +0300 Message-ID: Subject: Re: [PATCH 1/2] md: dm-verity: aggregate crypto API calls To: Yael Chemla Cc: Alasdair Kergon , Mike Snitzer , device-mapper development , Linux kernel mailing list , ofir.drang@gmail.com, Yael Chemla Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 25, 2018 at 9:41 PM, Yael Chemla wrote: > Current implementation makes multiple crypto API calls per block > implementation makes multiple crypto API calls per single block, > forcing underlying crypto tfm implementation to "stop & go", > leading to under utilization of HW engines. > To fix it unify calls to crypto init/update/final into a digest call > with a single sg which contains multiple buffers. > This is also needed as an enabler for the next patch in the series. > > > Signed-off-by: Yael Chemla > --- > drivers/md/dm-verity-target.c | 220 ++++++++++++++++++++++++------------------ > 1 file changed, 127 insertions(+), 93 deletions(-) Reviewed-by: Gilad Ben-Yossef -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru