From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 835BBC63777 for ; Sun, 22 Nov 2020 07:55:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F349208B3 for ; Sun, 22 Nov 2020 07:55:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=benyossef-com.20150623.gappssmtp.com header.i=@benyossef-com.20150623.gappssmtp.com header.b="ED9ZI38G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727344AbgKVHym (ORCPT ); Sun, 22 Nov 2020 02:54:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727307AbgKVHyl (ORCPT ); Sun, 22 Nov 2020 02:54:41 -0500 Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93DFEC0613CF for ; Sat, 21 Nov 2020 23:54:41 -0800 (PST) Received: by mail-yb1-xb42.google.com with SMTP id v92so12951758ybi.4 for ; Sat, 21 Nov 2020 23:54:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=benyossef-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cmv8Raua+1tSKqWDryWdApjoa82BkHH+3G4jECAsXHY=; b=ED9ZI38GM/y7HDpqvSCnHe7tcnjJBEwtQEWHzA1E4fmp26kYAJuZCcY5loygQ0Vw2b I9Rx1LfdG6Xzs/BUmw4dSQzNYuZyCyHbTb80hVACjZAIjlggQ33hjjYme4u/mFppXG/S GLNGkZDk+VFlOnxLNi4l3NDKnrclj5eqhRD4z0GUs5dbLY136oaoVN4SKSdn4XD/zA7k rMH44mXzrKDZboFuiwQHfpoeQEQe1jHsuNTXkJ3DJ+ArfjB5DA5TaPFzsPKhbI9G3d8s Uyfs0bN2fbLADGO7/dV5W5rO/KMdyLcq6tuexmFsmTnyG7Ci2xHGPe1+o6A20d8jWB9X q2iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cmv8Raua+1tSKqWDryWdApjoa82BkHH+3G4jECAsXHY=; b=PZtld0rTKv8LvMTIeAKCzV9ONx10cragCST5HskaTsC4K+GLCrRuYwdjm/ei5Dzn/W 6ynku6oJXOYfrwW6SIDafXeSTTOGYBk1WgF9sflTdAoXV8ZMt8NxGIlNFsUExlEQwQc7 K+DTVxbcUOXe7m0An6YfxH5Z7P2xkHRWbuZerSj+nc+mcJPRxKHO0Yeja7BMHv8oICij fo++/BOcEsqdaquaUiCsU/DTc0iegvA3jmjlz8TwWpziYorkGRmI9435ypDmTg2RTcBJ M80dCmNzKRemHJndwIHcAm3U3dx2BMLtDsOAGGKE7SLkdaFXZC7I0y+oufYUpO/Qo5Mb A2Jg== X-Gm-Message-State: AOAM532kGhqEWIf/pHwun26nc9eno20iIM2I5QQ0sgWJVHFAbpD744Xz /uX050MTb+BR42KeNyxTBaONL/3tmk4IzlAM51Ia4A== X-Google-Smtp-Source: ABdhPJyTrwkMPtEGxDAoEJwLclEl0SxjaSUTnkOaZ1BxWHJtYAl5yWfKV62ygcu2t61UEO4J7OTAcGncmare4c9rjuU= X-Received: by 2002:a25:2f51:: with SMTP id v78mr36598790ybv.235.1606031680454; Sat, 21 Nov 2020 23:54:40 -0800 (PST) MIME-Version: 1.0 References: <7c424191001cafdc7abd060790ecfcccdf3dd3ae.1605896059.git.gustavoars@kernel.org> In-Reply-To: <7c424191001cafdc7abd060790ecfcccdf3dd3ae.1605896059.git.gustavoars@kernel.org> From: Gilad Ben-Yossef Date: Sun, 22 Nov 2020 09:54:29 +0200 Message-ID: Subject: Re: [PATCH 075/141] crypto: ccree - Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" Cc: Herbert Xu , "David S. Miller" , Linux Crypto Mailing List , Linux kernel mailing list , linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 8:34 PM Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of > letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/crypto/ccree/cc_cipher.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_c= ipher.c > index dafa6577a845..cdfee501fbd9 100644 > --- a/drivers/crypto/ccree/cc_cipher.c > +++ b/drivers/crypto/ccree/cc_cipher.c > @@ -97,6 +97,7 @@ static int validate_keys_sizes(struct cc_cipher_ctx *ct= x_p, u32 size) > case S_DIN_to_SM4: > if (size =3D=3D SM4_KEY_SIZE) > return 0; > + break; > default: > break; > } > @@ -139,9 +140,11 @@ static int validate_data_size(struct cc_cipher_ctx *= ctx_p, > case DRV_CIPHER_CBC: > if (IS_ALIGNED(size, SM4_BLOCK_SIZE)) > return 0; > + break; > default: > break; > } > + break; > default: > break; > } > -- > 2.27.0 > Acked-by: Gilad Ben-Yossef Thanks, Gilad --=20 Gilad Ben-Yossef Chief Coffee Drinker values of =CE=B2 will give rise to dom!