From: Gilad Ben-Yossef <gilad@benyossef.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Chris Metcalf <cmetcalf@tilera.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Frederic Weisbecker <fweisbec@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
Matt Mackall <mpm@selenic.com>, Rik van Riel <riel@redhat.com>,
Andi Kleen <andi@firstfloor.org>,
Sasha Levin <levinsasha928@gmail.com>, Mel Gorman <mel@csn.ul.ie>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Avi Kivity <avi@redhat.com>,
Michal Nazarewicz <mina86@mina86.com>,
Kosaki Motohiro <kosaki.motohiro@gmail.com>,
Milton Miller <miltonm@bga.com>,
linux-kernel@vger.kernel.org
Subject: Re: [v7 1/8] smp: introduce a generic on_each_cpu_mask function
Date: Tue, 31 Jan 2012 08:33:03 +0200 [thread overview]
Message-ID: <CAOtvUMef-8p8WVL1uZEuMTOyiM+HTUDPjexw4jhL=0-xodta5w@mail.gmail.com> (raw)
In-Reply-To: <20120130135201.7bb5f173.akpm@linux-foundation.org>
On Mon, Jan 30, 2012 at 11:52 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Sun, 29 Jan 2012 14:24:16 +0200
> Gilad Ben-Yossef <gilad@benyossef.com> wrote:
>
>> On Thu, Jan 26, 2012 at 12:01 PM, Gilad Ben-Yossef <gilad@benyossef.com> wrote:
>> > on_each_cpu_mask calls a function on processors specified by
>> > cpumask, which may or may not include the local processor.
>> >
>> > You must not call this function with disabled interrupts or
>> > from a hardware interrupt handler or from a bottom half handler.
>> >
>> > Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
>> > Reviewed-by: Christoph Lameter <cl@linux.com>
>> > CC: Chris Metcalf <cmetcalf@tilera.com>
>> ...
>> > ---
>> > __include/linux/smp.h | __ 22 ++++++++++++++++++++++
>> > __kernel/smp.c __ __ __ __| __ 29 +++++++++++++++++++++++++++++
>> > __2 files changed, 51 insertions(+), 0 deletions(-)
>> >
>>
>>
>> Milton made the very sensible comment that while adding on_each_cpu() in the
>> arch generic code and removing the two arch specific instances from tile and arm
>> in separate patches is good for review, it will break bisect.
>>
>> He suggested I squash them into a single commit when it goes in.
>>
>> Since you picked the patch set into linux-mm, will now be a good time for that?
>
> I can fold the patches together - I do that all the time.
>
> Please identify exactly whcih patches you're referring to here.
>
> arm-move-arm-over-to-generic-on_each_cpu_mask and
> tile-move-tile-to-use-generic-on_each_cpu_mask should be folded into
> smp-introduce-a-generic-on_each_cpu_mask-function, yes?
Yes. Thank you.
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
gilad@benyossef.com
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com
"Unfortunately, cache misses are an equal opportunity pain provider."
-- Mike Galbraith, LKML
next prev parent reply other threads:[~2012-01-31 6:33 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 10:01 [v7 0/8] Reduce cross CPU IPI interference Gilad Ben-Yossef
2012-01-26 10:01 ` [v7 1/8] smp: introduce a generic on_each_cpu_mask function Gilad Ben-Yossef
2012-01-29 12:24 ` Gilad Ben-Yossef
2012-01-30 21:52 ` Andrew Morton
2012-01-31 6:33 ` Gilad Ben-Yossef [this message]
2012-01-26 10:01 ` [v7 2/8] arm: move arm over to generic on_each_cpu_mask Gilad Ben-Yossef
2012-01-26 10:01 ` [v7 3/8] tile: move tile to use " Gilad Ben-Yossef
2012-01-26 10:01 ` [v7 4/8] smp: add func to IPI cpus based on parameter func Gilad Ben-Yossef
2012-01-27 23:57 ` Andrew Morton
2012-01-29 12:04 ` Gilad Ben-Yossef
2012-01-26 10:01 ` [v7 5/8] slub: only IPI CPUs that have per cpu obj to flush Gilad Ben-Yossef
2012-01-26 15:09 ` Christoph Lameter
2012-01-26 10:01 ` [v7 6/8] fs: only send IPI to invalidate LRU BH when needed Gilad Ben-Yossef
2012-01-26 10:02 ` [v7 7/8] mm: only IPI CPUs to drain local pages if they exist Gilad Ben-Yossef
2012-01-26 15:13 ` Christoph Lameter
2012-01-28 0:12 ` Andrew Morton
2012-01-29 12:18 ` Gilad Ben-Yossef
2012-01-30 21:49 ` Andrew Morton
2012-01-31 6:32 ` Gilad Ben-Yossef
2012-01-30 14:59 ` Mel Gorman
2012-01-30 15:14 ` Gilad Ben-Yossef
2012-01-30 15:44 ` Mel Gorman
2012-01-26 10:02 ` [v7 8/8] mm: add vmstat counters for tracking PCP drains Gilad Ben-Yossef
2012-01-26 15:19 ` [v7 0/8] Reduce cross CPU IPI interference Peter Zijlstra
2012-01-29 8:25 ` Gilad Ben-Yossef
2012-02-01 17:04 ` Frederic Weisbecker
2012-02-02 8:46 ` Gilad Ben-Yossef
2012-02-02 15:41 ` Chris Metcalf
2012-02-05 11:46 ` Gilad Ben-Yossef
2012-02-10 18:39 ` Peter Zijlstra
2012-02-10 20:13 ` Gilad Ben-Yossef
2012-02-10 20:29 ` Peter Zijlstra
2012-02-10 20:39 ` Gilad Ben-Yossef
2012-02-10 18:33 ` Peter Zijlstra
2012-02-10 20:33 ` Gilad Ben-Yossef
2012-02-15 21:50 ` Chris Metcalf
2012-02-15 22:15 ` Christoph Lameter
2012-02-15 23:44 ` Chris Metcalf
2012-02-21 1:34 ` Frederic Weisbecker
2012-03-01 18:27 ` Chris Metcalf
2012-02-10 18:38 ` Peter Zijlstra
2012-02-10 20:24 ` Gilad Ben-Yossef
2012-02-15 15:11 ` Peter Zijlstra
2012-02-15 15:19 ` Gilad Ben-Yossef
2012-02-15 21:51 ` Chris Metcalf
2012-02-02 16:24 ` Frederic Weisbecker
2012-02-02 16:29 ` Christoph Lameter
2012-02-09 15:52 ` Frederic Weisbecker
2012-02-09 15:59 ` Chris Metcalf
2012-02-09 18:11 ` Frederic Weisbecker
2012-02-09 16:26 ` Christoph Lameter
2012-02-09 18:32 ` Frederic Weisbecker
2012-02-01 17:35 ` Peter Zijlstra
2012-02-01 17:57 ` Peter Zijlstra
2012-02-02 9:42 ` Gilad Ben-Yossef
2012-02-01 18:40 ` Paul E. McKenney
2012-02-01 20:06 ` Christoph Lameter
2012-02-01 20:13 ` Paul E. McKenney
2012-02-02 9:34 ` Avi Kivity
2012-02-02 15:34 ` Paul E. McKenney
2012-02-02 16:14 ` Avi Kivity
2012-02-02 17:01 ` Paul E. McKenney
2012-02-02 17:23 ` Avi Kivity
2012-02-02 17:51 ` Paul E. McKenney
2012-02-05 12:16 ` Avi Kivity
2012-02-05 16:59 ` Paul E. McKenney
2012-02-09 15:22 ` Frederic Weisbecker
2012-02-09 16:05 ` Avi Kivity
2012-02-09 18:22 ` Frederic Weisbecker
2012-02-09 23:41 ` Paul E. McKenney
2012-02-10 1:39 ` Frederic Weisbecker
2012-02-14 13:18 ` Avi Kivity
2012-02-21 0:02 ` Frederic Weisbecker
2012-02-02 17:25 ` Christoph Lameter
2012-02-05 12:06 ` Gilad Ben-Yossef
2012-02-06 18:19 ` Christoph Lameter
2012-02-09 15:37 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOtvUMef-8p8WVL1uZEuMTOyiM+HTUDPjexw4jhL=0-xodta5w@mail.gmail.com' \
--to=gilad@benyossef.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=cmetcalf@tilera.com \
--cc=fweisbec@gmail.com \
--cc=kosaki.motohiro@gmail.com \
--cc=levinsasha928@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mel@csn.ul.ie \
--cc=miltonm@bga.com \
--cc=mina86@mina86.com \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=riel@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).