From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DATE_IN_PAST_12_24, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 927AAC388F7 for ; Wed, 28 Oct 2020 23:59:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3059720829 for ; Wed, 28 Oct 2020 23:59:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=benyossef-com.20150623.gappssmtp.com header.i=@benyossef-com.20150623.gappssmtp.com header.b="L2xbAiWT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389340AbgJ1X74 (ORCPT ); Wed, 28 Oct 2020 19:59:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389114AbgJ1X6d (ORCPT ); Wed, 28 Oct 2020 19:58:33 -0400 Received: from mail-yb1-xb44.google.com (mail-yb1-xb44.google.com [IPv6:2607:f8b0:4864:20::b44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56774C0613D1 for ; Wed, 28 Oct 2020 16:58:33 -0700 (PDT) Received: by mail-yb1-xb44.google.com with SMTP id a12so657634ybg.9 for ; Wed, 28 Oct 2020 16:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=benyossef-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9ZlXToatDcyQe4UfooUu3JrhisJTqzWvPk9UeTaykHI=; b=L2xbAiWTTbIrt5K7yoWLPYgbHcR6JA3ygW52PmeYhcPUro9EBJ7jeSZ+LuUceUwi6h 7oJ0nyVewkcb5K+ygEJWYYMKXhaWMSobBdS26zzBkdJSzJLQfkJ9ORBytL4idG2x8OiJ 9aarfLTEzGCk1uCjCog7oi7V7msQ35V7eKNBN6lB3Pt0XeZUaZZGqxIfwBcha2zEJ3WN kZ9kfFU6h35Lf2aGkBLA0WhEm9MhweORqvnr/qOj6MkqYCWc4yB4rpgdiBoO/86iCgZ7 IEUBBDYCvLrMJVulHBHcZCHWqbinwfnCxIm8NM7pVPl6asD8IeCh1a7crlyWFtjVbf2K AdbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9ZlXToatDcyQe4UfooUu3JrhisJTqzWvPk9UeTaykHI=; b=I8PZ09oPXB78PGyi9oOD3gQUI8MUQtLtCeHQDqNWwBX0kKNdOPQmnqNh90H9ahTz6y wBcen74jY6JNhBI0OAFYMbtd1e10IypYfHUXyPfQGQXYYfNfJ9ff4eJidF8PSc3FY2KJ sD7Vi/M/pT8uj1WLWvHkL5GN+/Az7dG59BcpXEuAoQ7IolWFQieKEl18tMSiHT90GxdI SZ2em//OH/JxIv+dM7Gsr15kJxl7KfCE2lfuy/gXd1p5D0gGH5JDeK3agZ2fsfkOx/O7 Ra0aO50JvZebvnVE+Lkfe0EliUjehC/y+mCc9TNoQzs9zZRyAX1hi4lqimCOq3F8LKeU yARw== X-Gm-Message-State: AOAM532VdiKiyQtxjGH8f75u9oklG2e0lln8FE1gbqofeEchNY22dGiw 9A/dbmFUHkwsJU+1jJ4vE43J71XF2ZD6WlrA9nuQJH6g/KD37w== X-Google-Smtp-Source: ABdhPJwPEPpN0dIcKBfaGDgutMYF3sOkE6KoP9i1uddB1epbqqtMw2qCiW/gFeatIzJ1+Wk2li1pZyaWC1wQlcX+ghA= X-Received: by 2002:a25:41d0:: with SMTP id o199mr9520447yba.276.1603885293714; Wed, 28 Oct 2020 04:41:33 -0700 (PDT) MIME-Version: 1.0 References: <20201026130450.6947-1-gilad@benyossef.com> <20201026130450.6947-4-gilad@benyossef.com> <20201026175231.GG858@sol.localdomain> <20201026183936.GJ858@sol.localdomain> <20201026184155.GA6863@gondor.apana.org.au> <20201026184402.GA6908@gondor.apana.org.au> In-Reply-To: <20201026184402.GA6908@gondor.apana.org.au> From: Gilad Ben-Yossef Date: Wed, 28 Oct 2020 13:41:28 +0200 Message-ID: Subject: Re: [PATCH 3/4] dm crypt: switch to EBOIV crypto API template To: Herbert Xu Cc: Eric Biggers , Milan Broz , "David S. Miller" , Alasdair Kergon , Mike Snitzer , device-mapper development , Song Liu , Ofir Drang , Linux Crypto Mailing List , Linux kernel mailing list , linux-raid@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 26, 2020 at 8:44 PM Herbert Xu wr= ote: > > On Tue, Oct 27, 2020 at 05:41:55AM +1100, Herbert Xu wrote: > > > > The point is that people rebuilding their kernel can end up with a > > broken system. Just set a default on EBOIV if dm-crypt is on. > > That's not enough as it's an existing option. So we need to > add a new Kconfig option with a default equal to dm-crypt. Sorry if I'm being daft, but what did you refer to be "an existing option"? there was no CONFIG_EBOIV before my patchset, it was simply built as part of dm-crypt so it seems that setting CONFIG_EBOIV default to dm-crypto Kconfig option value does solves the problem, or have I missed something? Thanks, Gilad --=20 Gilad Ben-Yossef Chief Coffee Drinker values of =CE=B2 will give rise to dom!