From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752661AbcG2Tfg (ORCPT ); Fri, 29 Jul 2016 15:35:36 -0400 Received: from mail-yw0-f170.google.com ([209.85.161.170]:36416 "EHLO mail-yw0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbcG2Tf1 (ORCPT ); Fri, 29 Jul 2016 15:35:27 -0400 MIME-Version: 1.0 In-Reply-To: <1469722697-15220-1-git-send-email-weiyj.lk@gmail.com> References: <1469722697-15220-1-git-send-email-weiyj.lk@gmail.com> From: Sean Paul Date: Fri, 29 Jul 2016 15:35:05 -0400 Message-ID: Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation To: Wei Yongjun Cc: Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Dave Airlie , sonny.jiang@amd.com, leo.liu@amd.com, arindam.nath@amd.com, David1.Zhou@amd.com, Jammy.Zhou@amd.com, Monk.Liu@amd.com, dri-devel , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun wrote: > Use kmemdup rather than duplicating its implementation. > > Generated by: scripts/coccinelle/api/memdup.cocci > > Signed-off-by: Wei Yongjun Thanks for the patch. I'll apply this to -misc once the merge window is closed. Acked-by: Sean Paul > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > index a46a64c..b779b5f 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device *adev) > size = amdgpu_bo_size(adev->uvd.vcpu_bo); > ptr = adev->uvd.cpu_addr; > > - adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL); > + adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL); > if (!adev->uvd.saved_bo) > return -ENOMEM; > > - memcpy(adev->uvd.saved_bo, ptr, size); > - > return 0; > } > > > >