From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533AbcFWOXX (ORCPT ); Thu, 23 Jun 2016 10:23:23 -0400 Received: from mail-vk0-f41.google.com ([209.85.213.41]:36630 "EHLO mail-vk0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751037AbcFWOXV (ORCPT ); Thu, 23 Jun 2016 10:23:21 -0400 MIME-Version: 1.0 In-Reply-To: <1465904797-1117-1-git-send-email-ykk@rock-chips.com> References: <1465904718-663-1-git-send-email-ykk@rock-chips.com> <1465904797-1117-1-git-send-email-ykk@rock-chips.com> From: Sean Paul Date: Thu, 23 Jun 2016 10:22:58 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 09/10] drm/rockchip: analogix_dp: update the comments about why need to hardcode VOP output mode To: Yakir Yang Cc: Mark Yao , Inki Dae , Jingoo Han , Heiko Stuebner , Krzysztof Kozlowski , linux-samsung-soc , linux-rockchip@lists.infradead.org, Daniel Vetter , Emil Velikov , Douglas Anderson , dri-devel , Linux Kernel Mailing List , Javier Martinez Canillas , Tomasz Figa , =?UTF-8?Q?St=C3=A9phane_Marchesin?= , Thierry Reding , Dan Carpenter Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 14, 2016 at 7:46 AM, Yakir Yang wrote: > The hardware IC designed that VOP must output the RGB10 video format to > eDP contoller, and if eDP panel only support RGB8, then eDP contoller > should cut down the video data, not via VOP contoller, that's why we need > to hardcode the VOP output mode to RGA10 here. > > Signed-off-by: Yakir Yang > Acked-by: Mark Yao > Reviewed-by: Tomasz Figa > --- > Changes in v3: > - Add the reviewed flag from Tomasz. > [https://chromium-review.googlesource.com/#/c/346853/12] > - Add the acked flag from Mark. > > Changes in v2: > - new patch in v2 > > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > index 95a6f60..2ceb3f9 100644 > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > @@ -173,17 +173,11 @@ rockchip_dp_drm_encoder_atomic_check(struct drm_encoder *encoder, > int ret; > > /* > - * FIXME(Yakir): driver should configure the CRTC output video > - * mode with the display information which indicated the monitor > - * support colorimetry. > - * > - * But don't know why the CRTC driver seems could only output the > - * RGBaaa rightly. For example, if connect the "innolux,n116bge" > - * eDP screen, EDID would indicated that screen only accepted the > - * 6bpc mode. But if I configure CRTC to RGB666 output, then eDP > - * screen would show a blue picture (RGB888 show a green picture). > - * But if I configure CTRC to RGBaaa, and eDP driver still keep > - * RGB666 input video mode, then screen would works prefect. > + * The hardware IC designed that VOP must output the RGB10 video > + * format to eDP contoller, and if eDP panel only support RGB8, > + * then eDP contoller should cut down the video data, not via VOP > + * contoller, that's why we need to hardcode the VOP output mode > + * to RGA10 here. s/contoller/controller/ > */ > > ret = drm_of_encoder_active_endpoint_id(dp->dev->of_node, encoder); > -- > 1.9.1 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel