From: Sean Paul <seanpaul@chromium.org>
To: Caesar Wang <wxt@rock-chips.com>, Archit <architt@codeaurora.org>
Cc: Dave Airlie <airlied@linux.ie>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-rockchip@lists.infradead.org,
Brian Norris <briannorris@chromium.org>,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH] drm/bridge: analogix_dp: set the DPCD600 during disabling the psr
Date: Mon, 12 Dec 2016 09:58:49 -0500 [thread overview]
Message-ID: <CAOw6vb+zKuD-ijxQDtQwyozP6budBAKECTevUf83EEvqaDMQPQ@mail.gmail.com> (raw)
In-Reply-To: <1481338159-7189-1-git-send-email-wxt@rock-chips.com>
On Fri, Dec 9, 2016 at 9:49 PM, Caesar Wang <wxt@rock-chips.com> wrote:
> Look likes, the BOE panel FW didn't ack the DPCD600 signal from the host
> device, that will cause the panel hang on the startup display.
> The root cause we use the fast link mode during enter and exit the psr,
> this issue is gone if switching the fast link to main link mode.
>
Cc: Archit Taneja <architt@codeaurora.org>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> ---
>
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 6e0447f..6a5347b 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -133,6 +133,7 @@ int analogix_dp_disable_psr(struct device *dev)
> {
> struct analogix_dp_device *dp = dev_get_drvdata(dev);
> struct edp_vsc_psr psr_vsc;
> + int ret;
>
> if (!dp->psr_support)
> return -EINVAL;
> @@ -147,6 +148,10 @@ int analogix_dp_disable_psr(struct device *dev)
> psr_vsc.DB0 = 0;
> psr_vsc.DB1 = 0;
>
> + ret = drm_dp_dpcd_writeb(&dp->aux, DP_SET_POWER, DP_SET_POWER_D0);
> + if (ret != 1)
> + dev_err(dp->dev, "Failed to set DP Power0 %d\n", ret);
> +
> analogix_dp_send_psr_spd(dp, &psr_vsc);
> return 0;
> }
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-12-12 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 2:49 [PATCH] drm/bridge: analogix_dp: set the DPCD600 during disabling the psr Caesar Wang
2016-12-12 14:58 ` Sean Paul [this message]
2016-12-14 5:03 ` Archit Taneja
2016-12-14 10:00 ` Sean Paul
2016-12-15 9:37 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOw6vb+zKuD-ijxQDtQwyozP6budBAKECTevUf83EEvqaDMQPQ@mail.gmail.com \
--to=seanpaul@chromium.org \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=tomeu.vizoso@collabora.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).