From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752840AbcG2TlT (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 Jul 2016 15:41:19 -0400
Received: from mail-yw0-f179.google.com ([209.85.161.179]:33111 "EHLO
	mail-yw0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751529AbcG2TlI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Jul 2016 15:41:08 -0400
MIME-Version: 1.0
In-Reply-To: <CY4PR12MB13011FA11AA662DE894626C1F7010@CY4PR12MB1301.namprd12.prod.outlook.com>
References: <1469722697-15220-1-git-send-email-weiyj.lk@gmail.com>
 <CAOw6vb+Bn0vF5i-1DpTiSh3LBYzaP4VWF096oo2Mwxm_SSbHoQ@mail.gmail.com> <CY4PR12MB13011FA11AA662DE894626C1F7010@CY4PR12MB1301.namprd12.prod.outlook.com>
From: Sean Paul <seanpaul@google.com>
Date: Fri, 29 Jul 2016 15:40:48 -0400
Message-ID: <CAOw6vbKEAcXQ+36Q2sdg3kXRqob89aL+tnPaLpVLVy6DpGmByQ@mail.gmail.com>
Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation
To: "Deucher, Alexander" <Alexander.Deucher@amd.com>
Cc: Wei Yongjun <weiyj.lk@gmail.com>,
        "Koenig, Christian" <Christian.Koenig@amd.com>,
        Dave Airlie <airlied@linux.ie>, "Jiang, Sonny" <Sonny.Jiang@amd.com>,
        "Liu, Leo" <Leo.Liu@amd.com>, "Nath, Arindam" <Arindam.Nath@amd.com>,
        "Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
        "Zhou, Jammy" <Jammy.Zhou@amd.com>, "Liu, Monk" <Monk.Liu@amd.com>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 29, 2016 at 3:38 PM, Deucher, Alexander
<Alexander.Deucher@amd.com> wrote:
>> -----Original Message-----
>> From: Sean Paul [mailto:seanpaul@google.com]
>> Sent: Friday, July 29, 2016 3:35 PM
>> To: Wei Yongjun
>> Cc: Deucher, Alexander; Koenig, Christian; Dave Airlie; Jiang, Sonny; Liu, Leo;
>> Nath, Arindam; Zhou, David(ChunMing); Zhou, Jammy; Liu, Monk; dri-devel;
>> Linux Kernel Mailing List
>> Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than
>> duplicating its implementation
>>
>> On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
>> > Use kmemdup rather than duplicating its implementation.
>> >
>> > Generated by: scripts/coccinelle/api/memdup.cocci
>> >
>> > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>>
>>
>> Thanks for the patch. I'll apply this to -misc once the merge window is closed.
>>
>> Acked-by: Sean Paul <seanpaul@chromium.org>
>
> Unless you've already applied this to the misc tree, I'd prefer to take it via the amdgpu tree.
>

Nope, it's all yours.

Sean


> Alex
>
>>
>>
>> > ---
>> >  drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
>> >  1 file changed, 1 insertion(+), 3 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> > index a46a64c..b779b5f 100644
>> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> > @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device
>> *adev)
>> >         size = amdgpu_bo_size(adev->uvd.vcpu_bo);
>> >         ptr = adev->uvd.cpu_addr;
>> >
>> > -       adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
>> > +       adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
>> >         if (!adev->uvd.saved_bo)
>> >                 return -ENOMEM;
>> >
>> > -       memcpy(adev->uvd.saved_bo, ptr, size);
>> > -
>> >         return 0;
>> >  }
>> >
>> >
>> >
>> >